Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw 404 exception when get non-existing asset #480

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

yangyangv2
Copy link
Contributor

Summary

When ./getAsset on non-existing asset, it should throw 404 exception

Testing Done

unit test

Checklist

@yangyangv2 yangyangv2 force-pushed the yanyang/handle-get-non-existing-asset branch from 25a7008 to d4d9cef Compare November 25, 2024 22:30
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.16%. Comparing base (8ccc25e) to head (d4d9cef).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #480      +/-   ##
============================================
- Coverage     66.35%   66.16%   -0.19%     
- Complexity     1523     1527       +4     
============================================
  Files           137      137              
  Lines          5849     5891      +42     
  Branches        642      650       +8     
============================================
+ Hits           3881     3898      +17     
- Misses         1693     1713      +20     
- Partials        275      280       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jphui jphui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yangyangv2 yangyangv2 merged commit 6623691 into master Nov 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants