fix: getAspectClassNames to handle union alias #477
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Small fix of getAspectClassNames to handle union alias, to unblock EbeanLocalRelationshipQueryDAO.findEntities. (related to recent change in #436
The buggy behavior was that when aliases exists in the union type, this function will return the alias instead of the canonical name.
For example:
old code will return foo when we actually expects
com.linkedin.testing.EntityFoo
Testing Done
added unit test
./graldew build
Checklist