Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getAspectClassNames to handle union alias #477

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

ybz1013
Copy link
Contributor

@ybz1013 ybz1013 commented Nov 13, 2024

Summary

Small fix of getAspectClassNames to handle union alias, to unblock EbeanLocalRelationshipQueryDAO.findEntities. (related to recent change in #436

The buggy behavior was that when aliases exists in the union type, this function will return the alias instead of the canonical name.

For example:

typeref EntityUnionAlias = union[
  foo: EntityFoo,
  bar: EntityBar
]

old code will return foo when we actually expects com.linkedin.testing.EntityFoo

Testing Done

added unit test
./graldew build

Checklist

@ybz1013 ybz1013 requested review from zhixuanjia and jsdonn November 13, 2024 22:47
Copy link
Contributor

@jsdonn jsdonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proactively fixing the bug

@ybz1013 ybz1013 merged commit 2eb137c into linkedin:master Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants