Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: robust js/jsx whitespace handling #83

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

timofei-iatsenko
Copy link
Collaborator

Update to match JS version:
lingui/js-lingui#1882

Few notes:

  • I found that tests in current version are broken, they always pass no mater what. Turned out this is a bug in upstream. I didn't find a way to update only swc_ecma_transforms_testing without updating swc_core
  • Due to forementioned swc_core was bumped to the latest, and this will break compatibility with latest nextjs. It still uses older swc_core according to compatibility

This is a breaking change and should be merged synchronously with JS version.

src/jsx_visitor.rs Outdated Show resolved Hide resolved
@timofei-iatsenko timofei-iatsenko marked this pull request as draft March 29, 2024 12:18
@timofei-iatsenko
Copy link
Collaborator Author

will port lingui/js-lingui#1897 in this PR as well

@timofei-iatsenko
Copy link
Collaborator Author

done

@timofei-iatsenko timofei-iatsenko marked this pull request as ready for review March 29, 2024 12:44
@timofei-iatsenko timofei-iatsenko force-pushed the feature/whitespace-handling branch from a32e389 to b43ab5e Compare March 29, 2024 12:46
@timofei-iatsenko timofei-iatsenko merged commit f39f921 into next Mar 29, 2024
@timofei-iatsenko timofei-iatsenko deleted the feature/whitespace-handling branch March 29, 2024 14:50
@timofei-iatsenko timofei-iatsenko changed the title feature: robust JSX whitespace handling feature: robust whitespace handling Apr 18, 2024
@timofei-iatsenko timofei-iatsenko changed the title feature: robust whitespace handling feature: robust js/jsx whitespace handling Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants