build(swc_core)!: bump [email protected]

[dominikdosoudil]

Ident was replaced with IdentName and Ident was constructed without ctxt to conform [email protected]

All tests passed (on my machine 😄).

I've tested it in our company project with [email protected] as CONTRIBUTING guide suggests. Both build and dev seem to work without any issue.

I am not sure if I am supposed to add something to the README compatibility table. I think that it should be changed when new version is being released, right?

[timofei-iatsenko]

Thanks for the contribution. Generally, we align the plugin releases to latest stable version of nextjs. This is not ideal, but at least that make it work out of the box for people how starting the project and didn't read the instructions thoroughly.

But latest 4.0.9 already sabotaging this rule (it will work only with next@15-canary), so don't see anything against releasing this version as well.

[dominikdosoudil]

@thekip That's actually something I kinda expected that you're doing. And honestly I don't think that there is ideal solution to that. One might be forking it and maintaining "version" that aligns with rspack while the main repo would be aligned with next. However I think that it would make very difficult to sync features very soon as swc core seems to be releasing breaking changes almost nightly. Unfortunately it even cannot be expected that rspack won't upgrade swc core as it's under experimental configuration so I think they won't mind introducing breaking changes even in non-major releases.

However I am really up to migrating to rspack so wouldn't you be accepting this PR in the end, I would be most grateful if you shared any idea how to bring rspack compatible version (fork/branch/...) alive. I got almost none XP with libs so you might know better. Thanks and thanks for maintaining this lib!

[timofei-iatsenko]

You can take a binary from the output folder and simply put it into your repository, and start using it without waiting to get this merged. The plugins compatibility is a big pain now, unfortunately. I hope they will focus on this issue some day and will find a way how to make it without breaking changes. Interestingly that so many different bundlers/tools right now use SWC under the hood, and it seems they do not actively help to developing it, unfortunately.

[dominikdosoudil]

@thekip I don't think that it's worth creating issue, so I'll just drop it here:
There is a website that helps people select the right version of swc plugin. I haven't found if it's possible to contribute to the list however the list is pretty new as I understand, so IF they open the contrib, it might be useful. https://plugins.swc.rs/

[timofei-iatsenko]

@dominikdosoudil interesting, the lingui plugin is already in the list. SWC maintainers aware of us 👍. Thanks for the link.

[timofei-iatsenko]

it seems it's here and should pick up version automatically

https://github.com/swc-project/crawl-core-version/blob/main/pkgs/plugins/lingui-js.yml

[dominikdosoudil]

I see, well there seems to be some issue coz I use [email protected] which works with @lingui/[email protected] and it's not listed there if I select this version of rspack. That's why I thought that lingui is not there at all. I might look at it closer when I am back from vacation.

[czizzy]

Where is verison 4.0.9, is it unpublished?

[timofei-iatsenko]

🤨 @czizzy indeed, it wasn't published yet. @andrii-bodnar Could you make a release from a current main branch, please?

[andrii-bodnar]

@timofei-iatsenko just to double-check

Currently, we have swc_core version 0.96.9 in the main branch.

On the next branch we have 0.90.35. But we used to have 0.96.9 in the next branch, then we reverted it back due to some risks (#105).

So, should we release the main branch which contains swc_core 0.96.9?

[timofei-iatsenko]

Yes, newer SWC version in the next branch blocking testing v5 features for the devs. In the v4 branch there no such problem.

[andrii-bodnar]

Done - 4.0.9

[deysan]

@timofei-iatsenko The latest version of Rspack uses the new version of swc_core 0.99.5. It is not compatible with lingui/swc-plugin 4.0.9 plugin version. Will it be updated soon?

[timofei-iatsenko]

@andrii-bodnar let's now deploy another version with a swc_core from this PR.

[andrii-bodnar]

@timofei-iatsenko better 4.1.0 or 4.0.10?

[dominikdosoudil]

Last bump was patch so 4.0.10 seems more consistent. Even though it’s actually breaking change from my perspective.

[andrii-bodnar]

@dominikdosoudil why is this a breaking change? Will it affect @lingui/swc-plugin users somehow?

[timofei-iatsenko]

It's a breaking in some way, but we don't follow it for SWC bumps

[dominikdosoudil]

@andrii-bodnar imho because developer cannot blindly upgrade the plug-in without checking the compatibility table. Compilation would probably stop working. But because swc plugins are still kinda experimental and punk, it does not matter that much.

[Achaak]

Hi, I've just updated but it doesn't seem to work with version 14.2.11 of next.

[timofei-iatsenko]

@Achaak it shouldn't, check compatibility table.