Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update for v5 #1992

Merged
merged 6 commits into from
Aug 22, 2024
Merged

docs: update for v5 #1992

merged 6 commits into from
Aug 22, 2024

Conversation

timofei-iatsenko
Copy link
Collaborator

@timofei-iatsenko timofei-iatsenko commented Aug 7, 2024 •
edited
Loading

Description

docs update

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@vercel Vercel
Copy link

vercel bot commented Aug 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2024 7:38am

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.88 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.65 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

@timofei-iatsenko
Copy link
Collaborator Author

@andrii-bodnar i had to disable remark-lint-code-block-style because it gave me a false-positive warning, which i was not able to fix anyhow.

@andrii-bodnar andrii-bodnar requested a review from vonovak August 9, 2024 08:42
@andrii-bodnar
Copy link
Contributor

@thekip which snippet caused a false positive warning?

@timofei-iatsenko
Copy link
Collaborator Author

https://github.com/lingui/js-lingui/actions/runs/10285357541/job/28463421359

vonovak
vonovak reviewed Aug 10, 2024
View reviewed changes
Copy link
Collaborator

@vonovak vonovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited for v5! 💯

website/docs/ref/macro.mdx Show resolved Hide resolved
website/docs/releases/migration-5.md Outdated Show resolved Hide resolved
website/docs/releases/migration-5.md Outdated Show resolved Hide resolved
website/docs/ref/macro.mdx Outdated Show resolved Hide resolved
website/docs/ref/macro.mdx Outdated Show resolved Hide resolved
website/docs/releases/migration-5.md Outdated Show resolved Hide resolved
website/docs/releases/migration-5.md Outdated Show resolved Hide resolved
website/docs/tutorials/javascript.md Outdated Show resolved Hide resolved
website/docs/tutorials/react-patterns.md Outdated Show resolved Hide resolved
website/docs/tutorials/setup-react.mdx Outdated Show resolved Hide resolved
andrii-bodnar
andrii-bodnar approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thekip thank you!

@andrii-bodnar andrii-bodnar merged commit ae82906 into next Aug 22, 2024
15 checks passed
@andrii-bodnar andrii-bodnar deleted the docs/v5-update branch August 22, 2024 06:54
@andrii-bodnar andrii-bodnar added this to the v5 milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vonovak vonovak vonovak left review comments

@andrii-bodnar andrii-bodnar andrii-bodnar approved these changes

Assignees
No one assigned
Labels
📖 documentation
Projects
None yet
Milestone
v5
Development

Successfully merging this pull request may close these issues.
3 participants
@timofei-iatsenko @andrii-bodnar @vonovak