Skip to content

Add Kansai dialect entry to regional dialects JSON#7825

Merged
tentoumushii merged 1 commit intolingdojo:mainfrom
shogun444:patch-1
Mar 9, 2026
Merged

Add Kansai dialect entry to regional dialects JSON#7825
tentoumushii merged 1 commit intolingdojo:mainfrom
shogun444:patch-1

Conversation

@shogun444
Copy link
Contributor

@shogun444 shogun444 commented Mar 9, 2026

Added Kansai dialect entry to regional dialects JSON.

📝 Description

...

🔗 Related Issue

Closes #

🎯 Type of Change

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Documentation update (e.g., this file, README)
  • content: Content update (e.g., new kanji, vocab, or fonts in /static/)
  • style: UI/Theme changes (e.g., Tailwind, CSS, new themes)
  • refactor: Code refactor (no functional changes)
  • test: Test update (adding missing tests or correcting existing tests)
  • chore: Build, CI/CD, or dependency updates

🧪 How Has This Been Tested?

Test Steps:

  1. ...
  2. ...

Manual Test Checklist:

  • Tested in Kana dojo
  • Tested in Kanji dojo
  • Tested in Vocabulary dojo
  • Tested all 4 game modes (Pick, Reverse-Pick, Input, Reverse-Input)
  • ... (add any other specific tests)

📸 Screenshots/Videos (if applicable)

...

✅ Pre-Submission Checklist

  • My code follows the project's code style and uses cn() utility where needed.
  • I have run npm run check locally and there are no TypeScript/ESLint errors.
  • My commit messages follow the Conventional Commits format.
  • I have updated the documentation (if applicable).
  • This PR is against the main branch.

Helpful links: Contributing · Troubleshooting

📦 Additional Context

...

Added Kansai dialect entry to regional dialects JSON.


Signed-off-by: Sayandip Roy <161803450+shogun444@users.noreply.github.com>
@tentoumushii
Copy link
Collaborator

🎉 Thanks for your Pull Request, @shogun444!

We appreciate your contribution to KanaDojo!

Pre-merge checklist:

  • You starred our repo ⭐
  • Code follows project style guidelines
  • Changes have been tested locally
  • PR title is descriptive
  • If this closes an issue, it's linked with Closes #<number>

A maintainer will review your PR shortly. In the meantime, make sure all CI checks pass. You can run npm run check locally to match CI.

ありがとうございます! 🙏


🎴🗻 Welcome to KanaDojo! This appears to be your first contribution—that's awesome! We're thrilled to have you here. If you have any questions, don't hesitate to ask. 🏯

@tentoumushii
Copy link
Collaborator

🤖 Auto-Review: ✅ Passed

This regional dialect contribution has passed automated validation!

Checks passed:

  • ✅ File format is correct
  • ✅ Content is valid
  • ✅ Related issue found

Warnings:

  • ⚠️ Could not find a matching community issue for this regional dialect entry

Once the quality check passes, this PR will be automatically approved for merge.

@tentoumushii tentoumushii merged commit e20bdc0 into lingdojo:main Mar 9, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants