Merged
Conversation
deuszx
reviewed
Jul 3, 2025
Comment on lines
+1
to
+4
| VITE_FAUCET_URL=https://faucet.devnet-2025-06-27.linera.net/ | ||
| VITE_FUNGIBLE_APP_ID=bca9f0d106dadea4d7e879a729a3882a2c094ef1a0300596f64c5ce640f8cf10 | ||
| VITE_COUNTER_APP_ID=ef1977bfc2291069044a0650c73895d1ef8f8b1a850a5d8320c8da50b0c083c3 | ||
|
|
Contributor
There was a problem hiding this comment.
if we make defaults here use devnet maybe it's worth mentioning somewhere. I.e. devnets come and go, there are no promises to its lifetimes/availability so it might be surprising to people running.
Collaborator
Author
There was a problem hiding this comment.
I think it's documented by the faucet URL 🤔
The explainability without values here is arguably worse (it compiles correctly then at runtime errors in wasm-bindgen code on trying to deserialize undefined as a string 😬).
Contributor
There was a problem hiding this comment.
I think it's clearer when it doesn't work because it's EMPTY than when it's non-empty and doesn't work.
deuszx
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is essentially a backmerge of devnet/2025-06-27, but since we forbid merge commits we need to recreate all the commits for this branch.