Merge SourceCache into Collection #373
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INCOMPLETE:
fontiquetests pass;parleyneeds fixesFontContextis literally just aCollectionand aSourceCache. This collection already contains aQueryState, while performing a query also requires aSourceCache, so I don't see a good reason not to do this.Motivation: I am transitioning
kas-textto usefontiqueand will likely keep this as the primary text library in Kas since it integrates better with the widget lifecycle model. Parley is more capable, so makes more sense where complex text layout is required. I have a local hack adding optional Parley support to Kas, but this currently requires multiple instances of theCollection+SourceCache.Simpler solution: move
FontContexttofontique.Note also:
CollectionandSourceCachehave some option for internal sharing of state.