Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BreakReason public #300

Merged
merged 1 commit into from
Mar 16, 2025
Merged

Conversation

valadaptive
Copy link
Contributor

The break_reason accessor was public, but BreakReason was not, so nothing could be done with the accessor.

The `break_reason` accessor was public, but `BreakReason` was not, so
nothing could be done with it.
Copy link
Member

@xorgy xorgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issue with exposing this, since it is a plain copy enum.

@nicoburns nicoburns added this pull request to the merge queue Mar 16, 2025
Merged via the queue into linebender:main with commit 45d2e18 Mar 16, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants