[WIP] Vertical alignment #293
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes one vertical position as the origin, and aligns everything to that, e.g. if you select text-top, the glyph's ascender will be at the origin. This works well if every glyph has the same vertical alignment, but if not, it falls apart (e.g. if one glyph is aligned to text-top, and the next is aligned to text-bottom, they'll be extremely vertically separated). What CSS does is align everything using the metrics of the "parent style". I didn't get as far as implementing the alignment for actual glyph positioning, only line height calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes one vertical position as the origin, and aligns everything to that, e.g. if you select text-top, the glyph's ascender will be at the origin. This works well if every glyph has the same vertical alignment, but if not, it falls apart (e.g. if one glyph is aligned to text-top, and the next is aligned to text-bottom, they'll be extremely vertically separated). What CSS does is align everything using the metrics of the "parent style".
I didn't get as far as implementing the alignment for actual glyph positioning, only line height calculation.