Use Layout::width instead of calculating for alignment
#269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomcur
force-pushed
the
alignment-width
branch
from
681d5a1 to
a5c237a
Compare
nicoburns
approved these changes
Feb 6, 2025
tomcur
force-pushed
the
alignment-width
branch
from
a5c237a to
a2a8920
Compare
This does require line breaking to have happened, but that is already a requirement, as otherwise `Layout::lines` is empty.
tomcur
force-pushed
the
alignment-width
branch
from
a2a8920 to
ee6638f
Compare
tomcur
changed the title
Layout::full_width instead of calculating for alignmentLayout::width instead of calculating for alignment
I wondered the same thing, but opened the PR keeping the same behavior. I changed it to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does require line breaking to have happened, but that is already a requirement, as otherwise
Layout::linesis empty.This is a slight change in behavior, as trailing white space is no longer included in the alignment width.