Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #267

Merged
merged 7 commits into from
Feb 16, 2025
Merged

Conversation

nicoburns
Copy link
Contributor

This is just the result of running cargo update

Signed-off-by: Nico Burns <[email protected]>
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this PR is in service of a release, it also needs to update the Cargo.toml files.
We do the cargo upgrade and cargo update PRs as one PR.

@nicoburns nicoburns added this to the 0.3 Release milestone Feb 6, 2025
@nicoburns nicoburns changed the title Update lockfile Update dependencies Feb 6, 2025
@nicoburns
Copy link
Contributor Author

@DJMcNab Ok, this now upgrades everything except skrifa/read-fonts which I think ought to be handled separately because I'm not sure how that interacts with upgrading Swash's skrifa dep. @waywardmonkeys probably knows? Is skrifa a public dependency of Swash.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once CI is fixed, this seems reasonable.

I haven't carefully reviewed the FFI code. The macOS stuff is a trivially correct translation, I'm less sure about the windows change.

@nicoburns nicoburns force-pushed the cargo-update-20250207 branch 2 times, most recently from 254b892 to 0dc4306 Compare February 16, 2025 09:25
@nicoburns
Copy link
Contributor Author

I'm also not sure about the windows change. I've stripped it out for now so it can be reviewed separately.

@nicoburns nicoburns added this pull request to the merge queue Feb 16, 2025
Merged via the queue into linebender:main with commit 9d04520 Feb 16, 2025
42 checks passed
@nicoburns nicoburns deleted the cargo-update-20250207 branch February 16, 2025 09:40
@waywardmonkeys
Copy link
Contributor

I guess I'll have to rebase #252 now.

@waywardmonkeys
Copy link
Contributor

For future reference, since this is a library and not an application, you should get in the habit of doing default-features = false on objc2 crates as that changed in the update to 0.6 ... but I'll just get my #252 landed which already does that correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants