-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #267
Update dependencies #267
Conversation
Signed-off-by: Nico Burns <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this PR is in service of a release, it also needs to update the Cargo.toml files.
We do the cargo upgrade
and cargo update
PRs as one PR.
@DJMcNab Ok, this now upgrades everything except skrifa/read-fonts which I think ought to be handled separately because I'm not sure how that interacts with upgrading Swash's skrifa dep. @waywardmonkeys probably knows? Is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once CI is fixed, this seems reasonable.
I haven't carefully reviewed the FFI code. The macOS stuff is a trivially correct translation, I'm less sure about the windows change.
Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
254b892
to
0dc4306
Compare
I'm also not sure about the windows change. I've stripped it out for now so it can be reviewed separately. |
I guess I'll have to rebase #252 now. |
For future reference, since this is a library and not an application, you should get in the habit of doing |
This is just the result of running
cargo update