Handle inline boxes in cluster geometry and path #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inline boxes are currently silently ignored in some places, making text
selection wrong when they are used, as their advance is not used in
offset calculation and the run indices are counted wrong as the boxes
are skipped.
To see the issues currently present, insert the following in
`PlainEditor::update_layout` and run vello_editor.
```rust
builder.push_inline_box(crate::InlineBox {
id: 0,
index: 7,
width: 50.0,
height: 50.0,
});
```
This PR fixes the issues I've found, though the cursor position when the
cursor has a downstream affinity right on an inline box is still wrong,
I believe. For example, in "AB" with an inline box between "A" and "B",
when the cursor is between the two characters with downstream affinity,
still shows up on the right edge of the A.
tomcur
commented
Dec 6, 2024
tomcur
commented
Dec 6, 2024
| for (run_index, run) in line.runs().enumerate() { | ||
| for run_index in 0..line.len() { |
There was a problem hiding this comment.
Unfortunately we can't just use line.items(), as GlyphRunIter currently appears to skip the run on empty lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline boxes are currently silently ignored in some places, making text selection wrong when they are used, as their advance is not used in offset calculation and the run indices are counted wrong as the boxes are skipped.
To see the issues currently present, insert the following in
PlainEditor::update_layoutand run vello_editor.This PR fixes the issues I've found, though the cursor position when the cursor has a downstream affinity at the byte index of an inline box is still wrong, I believe. For example, in "AB" with an inline box between "A" and "B", when the cursor is between the two characters with downstream affinity, it shows up on the right side of the A, whereas it would be expected to show up at the left side of the B.