Separate error type for parse vs FromStr
#95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error type `ParseError` will shortly use a lifetime to have a lifetime bound tied to the input data. The error type for `FromStr` is not permitted to have a lifetime bound, so using the same type isn't possible.
|
Would it make sense to have a range of indexes in the error type instead to avoid this issue? (would also potentially be more convenient for consumers of the library if the error type isn't borrowing the input). |
|
I think Nico's suggestion of using a range makes sense. Having the range is also useful for consumers if they want to print an error message where the error is pointed out in context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error type
ParseErrorwill shortly use a lifetime to have a lifetime bound tied to the input data.The error type for
FromStris not permitted to have a lifetime bound, so using the same type isn't possible.