Move conversion logic into ColorSpace #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `convert` method to `ColorSpace`, and migrate logic in the individual color types to use that. One consequence is that gradient interpolation in Oklch is expected to be faster, as the conversion to Oklab for error evaluation now doesn't go all the way back to linear sRGB. Also adds examples from koloro crate, which were inadvertently omitted from the initial commit. Removes `TaggedColor::from_linear_srgb` method, as that functionality can now be expressed more idiomatically with properly typed colors.
We had the conversions in the tagged case but not for static color types.
DJMcNab
approved these changes
Nov 6, 2024
| @@ -145,6 +145,15 @@ impl ColorSpaceTag { | |||
| } | |||
| } | |||
|
|
|||
| pub fn convert(self, target: Self, src: [f32; 3]) -> [f32; 3] { | |||
There was a problem hiding this comment.
Maybe this could have a short doc comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
convertmethod toColorSpace, and migrate logic in the individual color types to use that.One consequence is that gradient interpolation in Oklch is expected to be faster, as the conversion to Oklab for error evaluation now doesn't go all the way back to linear sRGB.
Also adds examples from koloro crate, which were inadvertently omitted from the initial commit.
Removes
TaggedColor::from_linear_srgbmethod, as that functionality can now be expressed more idiomatically with properly typed colors.