Clamp alpha during parse, other tweaks #119
Merged
+66
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waywardmonkeys
force-pushed
the
fix-alpha-clamping
branch
from
23f9507 to
5b34d07
Compare
|
FWIW, I found this running some of the CSS tests from Simon Sapin. |
raphlinus
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Yes, this is more correct. Thanks!
I'm seeing where I went wrong. The language for rgb() says "Values outside these ranges are not invalid, but are clamped to the ranges defined here at parsed-value time." so I applied the alpha clamping there, but missed the broader statement in 4.2. Good catch, and a good argument for tests.
* § 4.2 of the CSS Color 4 spec states that the parsed alpha value will be clamped. * Add a new enum `Mode` to help indicate whether we're in modern or legacy parsing mode. This can be used in additional ways in subsequent commits to improve the strictness of parsing. * Reading an alpha value no longer automatically consumes trailing white space.
waywardmonkeys
force-pushed
the
fix-alpha-clamping
branch
from
5b34d07 to
99a8dce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modeto help indicate whether we're in modern or legacy parsing mode. This can be used in additional ways in subsequent commits to improve the strictness of parsing.