Serialize XyzD65 as xyz-d65
#118
Merged
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in § 14.4 of CSS Color 4 spec, colors specified in `xyz`, which is an alias of `xyz-d65`, are in the `xyz-d65` color space. We already only have a predefined colorspace for `XyzD65` and not just `Xyz`, but were serializing it out in the shorter form.
waywardmonkeys
force-pushed
the
resolve-xyz-as-xyz-d65
branch
from
7c5d46b to
4f55a59
Compare
tomcur
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in § 14.4 of CSS Color 4 spec, colors specified in
xyz, which is an alias ofxyz-d65, are in thexyz-d65color space.We already only have a predefined colorspace for
XyzD65and not justXyz, but were serializing it out in the shorter form.