Fix wrong classification of sending alert error#723
Merged
vincent-olivert-riera merged 1 commit intoline:masterfrom Apr 6, 2026
Merged
Conversation
At commit 359ca53, we added the categorize_error() function to classify the error_type of sending alert notification based on the HTTP code for the purpose of labeling metrics. However, there was a mistake causing error_type to always be "other_error". The reason is that the HTTP Requests library (requests) always returns False when executing the `bool (response)` statement in case of a response failure. (Ref: psf/requests#2002) We have fixed this issue and added the necessary tests for verification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At commit 359ca53, we added the categorize_error() function to classify the error_type of sending alert notification based on the HTTP code for the purpose of labeling metrics. However, there was a mistake causing error_type to always be "other_error". The reason is that the HTTP Requests library (requests) always returns False when executing the
bool (response)statement in case of a response failure. (Ref: psf/requests#2002)We have fixed this issue and added the necessary tests for verification.