Remove compiled messages from source code#722
Conversation
7f5acab to
be860de
Compare
vincent-olivert-riera
left a comment
There was a problem hiding this comment.
LGTM
Please squash the fixup commits.
9dcc0bd to
ae5baa9
Compare
|
@vincent-olivert-riera |
That option squashes all commits into a single one. This time there is only one commit, so squashing the fixup into that commits it's OK. But for other times, you have multiple commits and a few fixups, and you want to squash each fixup commit where it belongs, not everything into one. |
And this thing doesn't run recently, and it's very annoying... Could you rebase, squash and push? Let's see if it runs. |
|
Oh I see. I thought the behavior was the same with --autosquash. 🙇 |
Currently, every time we want to add or modify localized messages in Promgen, after editing the corresponding .po file, we compile it to create an .mo file which is a binary file, and then commit both files. This update removes .mo files from the repository to address several issues: 1. Security: Binary files might contain malicious code. 2. Transparency: Binary files are not human-readable, complicating change reviews. 3. Efficiency: Git is optimized for text files, leading to better storage and diffs. 4. Merge Conflicts: Binary files are difficult to merge, increasing error risks. Therefore, we have removed the .mo files from the repository and ensured they are compiled at runtime. We have added a step in the Dockerfile to compile these files, so they're included in the Docker image. Additionally, the Makefile now includes instructions for running Promgen locally.
ae5baa9 to
b7a4017
Compare

Currently, every time we want to add or modify localized messages in Promgen, after editing the corresponding .po file, we compile it to create an .mo file which is a binary file, and then commit both files. This update removes .mo files from the repository to address several issues:
Therefore, we have removed the .mo files from the repository and ensured they are compiled at runtime. We have added a step in the Dockerfile to compile these files, so they're included in the Docker image. Additionally, the Makefile now includes instructions for running Promgen locally.