Remove the registry interface and improve plugin interface code quality #119
+42
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in issue #118, Flutter has completely removed the
PluginRegistryinterface from the engine codebase (see flutter/engine#52022). This means that in the next stable release, possibly as soon as version 3.28.0, any code usingPluginRegistrywill fail to compile.Given that the
PluginRegistryAPI was deprecated years ago and that nearly all users should now be using the v2 plugin interface, it seems quite safe to remove this from our codebase as well.Strictly speaking, this type of change should result in a major version update since it introduces breaking changes. However, it appears that Flutter itself isn't adhering strictly to this convention. Therefore, we plan to release this change in the next minor version as well.