Skip to content

Add optional random server selection for TCP and HTTP backends #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −2
Open

Add optional random server selection for TCP and HTTP backends #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43c7303
Add support for random server selection in TCP and HTTP backends
mertemr Jun 14, 2025
0a85e28
Fix condition checks for random server selection in TCP and HTTP back…
mertemr Jun 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mjml/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

# tcpserver backend mode configs
MJML_TCPSERVERS = getattr(settings, 'MJML_TCPSERVERS', [('127.0.0.1', 28101)])
MJML_TCPSERVERS_USE_RANDOM = getattr(settings, 'MJML_TCPSERVERS_RANDOM', True)
assert isinstance(MJML_TCPSERVERS, (list, tuple))
for t in MJML_TCPSERVERS:
assert isinstance(t, (list, tuple)) and len(t) == 2 and isinstance(t[0], str) and isinstance(t[1], int)
Expand All @@ -18,6 +19,7 @@
'URL': 'https://api.mjml.io/v1/render',
'HTTP_AUTH': None, # None (default) or ('login', 'password')
}])
MJML_HTTPSERVERS_USE_RANDOM = getattr(settings, 'MJML_HTTPSERVERS_RANDOM', True)
assert isinstance(MJML_HTTPSERVERS, (list, tuple))
for t in MJML_HTTPSERVERS:
assert isinstance(t, dict)
Expand Down
6 changes: 4 additions & 2 deletions mjml/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ def socket_recvall(sock: socket.socket, n: int) -> Optional[bytes]:
def _mjml_render_by_tcpserver(mjml_code: str) -> str:
if len(mjml_settings.MJML_TCPSERVERS) > 1:
servers = list(mjml_settings.MJML_TCPSERVERS)[:]
random.shuffle(servers)
if mjml_settings.MJML_TCPSERVERS_USE_RANDOM is True:
random.shuffle(servers)
else:
servers = mjml_settings.MJML_TCPSERVERS
mjml_code_data = force_bytes(mjml_code)
Expand Down Expand Up @@ -102,7 +103,8 @@ def _mjml_render_by_httpserver(mjml_code: str) -> str:

if len(mjml_settings.MJML_HTTPSERVERS) > 1:
servers = list(mjml_settings.MJML_HTTPSERVERS)[:]
random.shuffle(servers)
if mjml_settings.MJML_HTTPSERVERS_USE_RANDOM is True:
random.shuffle(servers)
else:
servers = mjml_settings.MJML_HTTPSERVERS

Expand Down