portfwd: support HostSocket
#4008
Open
+81
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norio-nomura
force-pushed
the
portfwd-support-host-socket
branch
2 times, most recently
from
277bbce to
141e02e
Compare
norio-nomura
force-pushed
the
portfwd-support-host-socket
branch
2 times, most recently
from
64a2088 to
991e95f
Compare
|
Dropped closing |
norio-nomura
force-pushed
the
portfwd-support-host-socket
branch
from
991e95f to
935aa20
Compare
AkihiroSuda
previously approved these changes
Sep 19, 2025
norio-nomura
force-pushed
the
portfwd-support-host-socket
branch
from
935aa20 to
e7a9d6b
Compare
|
added a test to |
norio-nomura
force-pushed
the
portfwd-support-host-socket
branch
4 times, most recently
from
bedf7de to
7ef6404
Compare
|
I give up on making hostSocket tests pass on Windows, since I don't have any Windows environments for debugging. |
|
Afaik there is no AF_UNIX interop between WSL2 and Windows; it only worked for WSL, but has never been implemented for WSL2. |
norio-nomura
force-pushed
the
portfwd-support-host-socket
branch
3 times, most recently
from
8c60f68 to
5ec1a53
Compare
norio-nomura
force-pushed
the
portfwd-support-host-socket
branch
3 times, most recently
from
b80fe85 to
37c46c8
Compare
Signed-off-by: Norio Nomura <[email protected]> portfwd: remove "unixgram" forwarding code because that does not work Signed-off-by: Norio Nomura <[email protected]> portfwd: do not use `listenConfig` param on Unix domain sockets Signed-off-by: Norio Nomura <[email protected]>
Signed-off-by: Norio Nomura <[email protected]> hack/test-port-forwarding.pl: use platform-independent path on hostSocket Signed-off-by: Norio Nomura <[email protected]> hack/test-port-forwarding.pl: Skip hostSocket test on Windows host Signed-off-by: Norio Nomura <[email protected]>
norio-nomura
force-pushed
the
portfwd-support-host-socket
branch
from
37c46c8 to
ef88218
Compare
I didn’t give up, even though I said I had. But this time, I truly gave up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing
hostSocketsupport to GRPC port forwarder.HostPortRangeifHostSocketis used.edit: dropped closing
ClosableListenerson exit