Skip to content

decoupling imgutils from filenams #3523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

jonas-peter
Copy link
Contributor

As a "good first issue", fixing #3517

@jonas-peter jonas-peter requested a review from jandubois May 9, 2025 17:00
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

Please squash commits though!

@AkihiroSuda
Copy link
Member

Please squash the commits

@AkihiroSuda AkihiroSuda added the kind/refactoring Refactoring label May 9, 2025
@AkihiroSuda AkihiroSuda added this to the v1.1.0 milestone May 9, 2025
@jonas-peter jonas-peter force-pushed the decoupling_imgutil branch from 818c4bb to 59bc4dd Compare May 9, 2025 17:10
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois merged commit 61bb7ef into lima-vm:master May 9, 2025
58 of 59 checks passed
@AkihiroSuda AkihiroSuda linked an issue May 9, 2025 that may be closed by this pull request
@jonas-peter jonas-peter deleted the decoupling_imgutil branch May 9, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactoring Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

imgutil should be decoupled fromfilenames
3 participants