Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usages of usr.HomeDir with os.UserHomeDir() #3385

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Replace usages of usr.HomeDir with os.UserHomeDir() #3385

merged 1 commit into from
Apr 1, 2025

Conversation

kairveeehh
Copy link
Contributor

fixes #3374

@AkihiroSuda
Copy link
Member

CI is failing

alexandear
alexandear reviewed Mar 28, 2025
View reviewed changes
alexandear
alexandear suggested changes Mar 28, 2025
View reviewed changes
Copy link
Member

@alexandear alexandear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix CI.

@kairveeehh kairveeehh force-pushed the fix branch 3 times, most recently from 88d054a to 4a9632d Compare March 28, 2025 13:35
@kairveeehh kairveeehh requested a review from alexandear March 29, 2025 03:12
alexandear
alexandear suggested changes Mar 29, 2025
View reviewed changes
Copy link
Member

@alexandear alexandear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update also TestPrintInstanceTableHome with os.UserHomeDir()

@kairveeehh kairveeehh force-pushed the fix branch 6 times, most recently from 01f5e0d to 4f0b656 Compare March 29, 2025 12:08
jandubois
jandubois approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois merged commit 60f6e0b into lima-vm:master Apr 1, 2025
31 checks passed
@jandubois jandubois added this to the v1.1.0 milestone Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jandubois jandubois jandubois approved these changes

@alexandear alexandear alexandear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Replace usages of usr.HomeDir with os.UserHomeDir()
4 participants
@kairveeehh @AkihiroSuda @jandubois @alexandear