Skip to content

Convert real stack 17 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 76 commits into
base: master
Choose a base branch
from

Conversation

shirapahmer
Copy link

This is a converted stack class that uses the drawable.py file instead of the recordclass library.
An issue we noticed that has to do with the VisualizationApp.py file is that if an invalid number is entered in the Operations table on the visualization, the Operations grid moves over to the right a few spaces as it displays its error message.

Moved all initialization into app construtor. Changed initial load
to be 8 random numbers but used fixed seed from command line launch
for later regression tests.
Strangely, importing packages in the same directory didn't work when
importing the entire PythonVisualizations library.  I had to import
them with a leading period to show they were relative.  That broke
loading them when importing while the current directory is
PythonVisualizations.  The result is, the code tries to load them
one way and fails over to the other method if it can't find them.
…lization

All animations now use moveItems to perform a linear movement of canvas
items.  The insert operation animates the arrival of the new value in the
array cell.
… goal

Moved more animation routines into VisualizationApp and made use of
them for Array.
The AlgorithmVisualizations.py application now discovers and displays
a partially working Simple Sorting visualization.
JMCanning78 and others added 28 commits May 24, 2020 10:42
The AlgorithmVisualizations.py application now discovers and displays
a partially working Simple Sorting visualization.
Also fixed a bug with the find operation in SimpleSorting.py
Highlighting only set up for InsertionSort.
Changed representation of cleanup to be a set for easier removal of items.
This is a Stack class that runs with drawable.py instead of the recordclass library
Copy link
Owner

@lilypolonetsky lilypolonetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please resubmit the pull request to the jmcanning78/datastructures-visualization repo instead? Thanks!

@JMCanning78 JMCanning78 deleted the convert-realStack-17 branch June 10, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants