Update and improve dev env, testing, building and publishing#143
Merged
Conversation
Use this instead of manually manipulating the script
c310b94 to
e5e379a
Compare
The 5-apps image activates AppArmor for the Supervisor and apps whenever the host kernel supports it, which it does on GHA ubuntu-latest runners. That confines the PostgreSQL add-on under its AppArmor profile, and on Ubuntu kernels the profile either fails to apply (runc: "no such file or directory" on .../attr/apparmor/exec) or slows initdb enough to blow the 2-minute startup timeout. SUPERVISOR_UNCONFINED only unconfines the Supervisor container, not the apps, so it doesn't help here. Switch to the 4-apps image, which doesn't activate AppArmor in the devcontainer, so add-ons run unconfined and PostgreSQL starts cleanly - matching the proven-working ha-addon-ghostfolio setup. Also drop the SUPERVISOR_CHANNEL=beta debugging artifact, which is unrelated and not needed.
5faefa3 to
76499d8
Compare
26fc73d to
0ab14a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the devcontainer configuration to use the newer app config.
Move away from the legacy build.json file.
Switch to the newer publish image.
Also adds a script for setting up a local dev container and then use that in an integration test to ensure the addon can be installed, configured and started with all PRs so I don't have to do it manually.