likenft-indexer: batch BookNFT eth_getLogs calls to reduce Alchemy CU…

[williamchong]

… spend

Batch per-contract acquire-book-nft-events tasks into groups of 50 (configurable via TASK_ACQUIRE_BOOKNFT_BATCH_SIZE). The inner handler already supports multiple addresses, so this change is purely in the task wrapping and enqueuing layer.

• Add TaskAcquireBookNFTBatchSize config field
• Change lifecycle task payload to accept []string with backward compat
• Batch lifecycles before enqueuing, one asynq task per batch
• Enqueue inside WithEnqueueing callback to avoid orphaned lifecycles
• Guard against negative fetch count when queue is full
• Add per-address fallback when batched eth_getLogs exceeds response limits

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Rolling deploy compatibility risk: NewTypeAcquireBookNFTEventsTaskPayloadWithLifecycle now only serializes ContractAddresses. Any older worker binary that still expects ContractAddress will treat new tasks as empty and likely fail. If mixed versions can run concurrently, consider a rollout guard (e.g., keep batch size = 1 until all workers are updated) and/or populate ContractAddress when len(contractAddresses)==1 so single-address tasks remain readable by older code.

[Copilot]

TaskAcquireBookNFTMaxQueueLength is now used as a contracts-in-flight limit (tasks * batchSize), but the name/env var still reads like a task-queue-length limit. This can lead to surprising production behavior/configuration mistakes (e.g., default 500 becomes only 10 tasks at batchSize=50). Consider introducing a clearly named config for contract-level concurrency (or renaming the field and keeping the old env var as a deprecated alias).

Suggested change

	// Each queued task now represents a batch of contracts.
	// NOTE: TaskAcquireBookNFTMaxQueueLength is effectively a limit on contracts
	// in flight (tasks * batchSize), not a limit on the raw number of queued tasks.
	estimatedContractsInFlight := currentLength * batchSize
	maxContractsInFlight := config.TaskAcquireBookNFTMaxQueueLength
	numberOfItemsToBeFetched := maxContractsInFlight - estimatedContractsInFlight
	if numberOfItemsToBeFetched <= 0 {
	mylogger.Info("queue is full, skipping", "estimatedContractsInFlight", estimatedContractsInFlight)
	return nil
	}
	// Each queued task represents a batch of contracts. The configuration
	// TaskAcquireBookNFTMaxQueueLength is interpreted as a limit on the number
	// of queued tasks (pending + active). We derive how many contracts we can
	// fetch from that task-level limit and the configured batch size.
	maxTasksInQueue := config.TaskAcquireBookNFTMaxQueueLength
	numberOfTasksToEnqueue := maxTasksInQueue - currentLength
	if numberOfTasksToEnqueue <= 0 {
	mylogger.Info("queue is full, skipping", "currentLength", currentLength, "maxTasksInQueue", maxTasksInQueue)
	return nil
	}
	numberOfItemsToBeFetched := numberOfTasksToEnqueue * batchSize

[rickmak]

Merge via 312da07