velike: Remove Lock of reward, allow new reward contract to deploy and partial withdraw by rickmak · Pull Request #307 · likecoin/likecoin-op

rickmak · 2026-02-27T11:11:44Z

Decision notes:

The new reward is auto enrol. no user action is need to entitle the newly assigned reward.
Allow partial withdraw as no longer lock to encourage even withdraw, don't withdraw all. (parital withdraw will also claim reward as of now)
Allow the admin/user to claim the previous vault reward after assigned a new vault.

…ove period lock - Change IRewardContract.withdraw(address) to withdraw(address, uint256) - Remove _isActive() check from veLikeReward.withdraw() so users can withdraw anytime - Support partial withdraw by subtracting the specified amount instead of zeroing - Update veLike._withdraw() to pass assets amount to reward contract

- Add isLegacyRewardContract mapping to veLikeStorage for allowlisting old reward contracts - Add setLegacyRewardContract(address, bool) owner function to manage the allowlist - Add claimLegacyReward(address) user-callable function to claim from rotated-out reward contracts - Add ErrNotLegacyRewardContract error for unauthorized legacy reward claims

- Remove setLockTime from test factory (no-lock operational model) - Replace 'lockable vault' test section with 'no-lock vault' tests - Add test: withdraw during active reward period succeeds - Add test: partial withdraw keeps remaining stake - Add test: reward tracking after partial withdraw is correct - Preserve existing post-period withdraw and claim tests

- Test setLegacyRewardContract owner-only access control - Test claimLegacyReward reverts on non-allowlisted contract - Test claimLegacyReward succeeds after allowlisting and rotation - Test claimLegacyReward reverts after removing from allowlist

Copy veLikeReward.sol as veLikeRewardNoLock.sol with only the contract name renamed. This serves as the base for the no-lock reward contract changes in the next commit.

ckxpress · 2026-02-27T11:17:47Z

"auto enrol" means what

rickmak · 2026-02-27T11:19:08Z

enroll* , it means no user action is needed to entitle the new reward assigned to veLike.

Copilot

Pull request overview

This PR updates the veLike staking/reward flow to support a no-lock vault model, partial withdrawals, reward contract rotation to a new veLikeRewardNoLock implementation, and user/admin claiming of rewards from rotated-out (legacy) reward contracts.

Changes:

Move lock enforcement to veLike (via lockTime) and enable partial withdrawals by passing amount through to reward contracts.
Add veLikeRewardNoLock reward contract + Ignition module + test fixtures and integration tests for rotation/auto-enrollment.
Add legacy reward allowlisting + claimLegacyReward entrypoint and a Hardhat task to claim legacy rewards.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
likecoin3/test/veLike.ts	Adds extensive test coverage for no-lock withdrawals, partial withdraw reward math, reward rotation/auto-enrollment, and legacy reward claiming.
likecoin3/test/factory.ts	Adjusts fixtures to default to no-lock behavior and adds NoLock-specific deployment/condition helpers.
likecoin3/tasks/staking.ts	Adds a Hardhat task for calling `veLike.claimLegacyReward(...)` in ops flows.
likecoin3/ignition/modules/veLikeRewardNoLock.ts	Adds Ignition module to deploy/configure `veLikeRewardNoLock` behind an ERC1967Proxy and initialize `totalStaked`.
likecoin3/contracts/veLikeRewardNoLock.sol	Introduces the new reward implementation supporting lazy staker sync (auto-enrollment) after rotation.
likecoin3/contracts/veLikeReward.sol	Updates reward withdraw handling to accept an `amount` (enabling partial withdraw) and removes withdraw-time active-period locking.
likecoin3/contracts/veLike.sol	Updates reward interface to pass withdraw amounts, moves lock enforcement into vault withdraw, and adds legacy reward allowlist + claim entrypoint.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-27T11:41:39Z

likecoin3/contracts/veLikeRewardNoLock.sol

+     * correct denominator that includes all existing vault holders.
+     */
+    function initTotalStaked() external onlyOwner {
+        veLikeRewardStorage storage $ = _getveLikeRewardData();


initTotalStaked() can be called repeatedly and will overwrite totalStaked based on the current vault totalSupply(). If this is called after deposits/withdrawals have already been tracked in stakerInfos, it will desync accounting and can break reward distribution. Consider guarding it so it can only be executed once (e.g., require !autoSyncEnabled) and/or only before any staking condition has started.

Suggested change

veLikeRewardStorage storage $ = _getveLikeRewardData();

veLikeRewardStorage storage $ = _getveLikeRewardData();

// Prevent re-initialization, which would desync accounting once staking is live.

require(!$.autoSyncEnabled, "Already initialized");

Copilot · 2026-02-27T11:41:40Z

likecoin3/contracts/veLikeReward.sol

+    function withdraw(
+        address account,
+        uint256 amount
+    ) public whenNotPaused onlyVault {
        veLikeRewardStorage storage $ = _getveLikeRewardData();
-        if (_isActive()) {
-            revert ErrWithdrawLocked();
-        }
        _updateVault();
        _claimReward(account, false);
-        $.totalStaked -= $.stakerInfos[account].stakedAmount;
-        $.stakerInfos[account].stakedAmount = 0;
+        $.totalStaked -= amount;
+        $.stakerInfos[account].stakedAmount -= amount;
    }


After removing the withdraw-time lock from withdraw(), the ErrWithdrawLocked custom error declared in this contract is no longer referenced anywhere in veLikeReward.sol. Consider removing it to avoid confusion about where the lock is enforced (it now appears to be enforced in veLike).

- Remove ErrWithdrawLocked dead code - Add autoSyncEnabled flag to storage for rotation safety - Add _effectiveStakedAmount() for vault-balance fallback on un-synced stakers - Add _syncStaker() for lazy enrollment of pre-rotation stakers - Add initTotalStaked() to set denominator from vault totalSupply - Guard getPendingReward against division by zero (totalStaked==0, endTime<=startTime) - Call _syncStaker in deposit, withdraw, and claimReward paths

Move rewardContract.deposit() before _mint() so that _syncStaker reads the pre-deposit balanceOf for correct retroactive reward math. Without this, vault.balanceOf(account) inside _syncStaker would include the new deposit, causing incorrect stakedAmount initialization.

…lment Add deployVeLikeRewardNoLock, initialMintNoLock, and initialConditionNoLock fixtures in factory.ts. Update veLike.ts to use NoLock fixtures for no-lock, legacy, and integration tests. Integration test verifies auto-enrollment with initTotalStaked(), retroactive rewards, and correct reward math across rotation.

Deploy veLikeRewardNoLock proxy with setVault, setLikecoin, and initTotalStaked calls included in the deployment script so that the reward contract is fully configured for reward rotation with auto-enrollment of existing stakers.

rickmak · 2026-03-01T12:09:07Z

Updated the PR to better address the auto enroll and potential 3rd Reward contract.

If the user has zero interaction with reward, i.e. not adding/claim/withdraw. Admin will need to sync before rotating out the reward contract. Otherwise, that user will not able to claim the rewards.

So marketing-wise, we can ask user to have some kind of interaction with the veLike reward. or just do it silently on new reward is assigned.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-02T10:52:23Z

likecoin3/contracts/veLikeRewardNoLock.sol

+        uint256 targetTime = block.timestamp;
+        if (targetTime > $.currentStakingCondition.endTime) {
+            targetTime = $.currentStakingCondition.endTime;
+        }
+        uint256 timePassed = targetTime - $.lastRewardTime;
+        uint256 newReward = timePassed *
+            _rewardPerTimeWithPrecision($.currentStakingCondition);


getPendingReward() can underflow and revert when queried before the reward period starts: timePassed = targetTime - lastRewardTime while lastRewardTime is set to startTime in addReward. Consider clamping targetTime to max(startTime, lastRewardTime) (similar to _updateVault) or early-returning calculatedReward when block.timestamp < startTime so reads are safe pre-start.

Copilot · 2026-03-02T10:52:23Z

likecoin3/contracts/veLikeRewardNoLock.sol

+        if (startTime <= $.lastRewardTime) {
+            revert ErrConflictCondition();
+        }
+        if (endTime < startTime) {
+            revert ErrConflictCondition();
+        }
+        if (endTime < block.timestamp) {
+            revert ErrConflictCondition();
+        }


In addReward, endTime == startTime is currently allowed (endTime < startTime), but _rewardPerTimeWithPrecision() later divides by (endTime - startTime) and will revert on zero-length periods. Reject endTime <= startTime (or handle zero-duration explicitly) to avoid a configuration that bricks the reward contract at runtime.

williamchong · 2026-03-02T18:08:13Z

likecoin3/contracts/veLikeReward.sol

+        $.totalStaked -= amount;
+        $.stakerInfos[account].stakedAmount -= amount;


Do we need to check $.totalStaked >= amount;?

It should keep track correctly, I updated the op manual. The amount should have sync via _syncStaker in new noLock reward. For the 1st vault, it should no longer call this after the interface update.

hmm, so you are right, this update is not necessary for the first lock, we can keep the old logic.

williamchong · 2026-03-02T19:06:40Z

likecoin3/contracts/veLikeRewardNoLock.sol

+        _syncStaker(account);
+        _updateVault();
+        _claimReward(account, false);
+        $.totalStaked -= amount;


not sure if we should check $.totalStaked >= amount

It will prevent operational error

Try to follow the official guide: https://hardhat.org/ignition/docs/guides/upgradeable-proxies Checkout the veLike and vLikeReward from 93da984 and move current code as V2

rickmak added 7 commits February 27, 2026 08:55

test: add legacy reward claim tests

4e74282

- Test setLegacyRewardContract owner-only access control - Test claimLegacyReward reverts on non-allowlisted contract - Test claimLegacyReward succeeds after allowlisting and rotation - Test claimLegacyReward reverts after removing from allowlist

test: add reward rotation integration test

0ad5aab

veLike: add claimLegacyReward hardhat task

11cb16f

veLikeRewardNoLock: copy veLikeReward as starting point

ab2744d

Copy veLikeReward.sol as veLikeRewardNoLock.sol with only the contract name renamed. This serves as the base for the no-lock reward contract changes in the next commit.

rickmak assigned williamchong Feb 27, 2026

rickmak changed the title ~~eelike: Remove Lock of reward, allow new reward contract to deploy and partial withdraw~~ velike: Remove Lock of reward, allow new reward contract to deploy and partial withdraw Feb 27, 2026

nwingt requested a review from Copilot February 27, 2026 11:29

Copilot started reviewing on behalf of nwingt February 27, 2026 11:29 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

rickmak added 7 commits March 1, 2026 11:07

ignition: add veLikeRewardNoLock deployment module

2e7011a

Deploy veLikeRewardNoLock proxy with setVault, setLikecoin, and initTotalStaked calls included in the deployment script so that the reward contract is fully configured for reward rotation with auto-enrollment of existing stakers.

chore: Run prettier

6c8ea4c

test: add legacy reward with lock rotation test

19a9acd

test: add syncStakers and stale-balance fix tests

b021b66

rickmak force-pushed the velike-nolock branch from bbdd7ee to b021b66 Compare March 1, 2026 11:53

williamchong requested a review from Copilot March 2, 2026 10:11

Copilot started reviewing on behalf of williamchong March 2, 2026 10:11 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

williamchong requested a review from Copilot March 2, 2026 10:38

Copilot started reviewing on behalf of williamchong March 2, 2026 10:38 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

williamchong reviewed Mar 2, 2026

View reviewed changes

rickmak added 5 commits March 3, 2026 16:46

veLike: add test for multiple claim of LegacyReward and lazy rollover

1c45529

veLike: add deployment operation doc

72fdde0

veLike: Address comments on extra guard in initTotalStaked

4199430

It will prevent operational error

veLike: Add veLikeUpgradeV2 ignition modules

5f0872a

Try to follow the official guide: https://hardhat.org/ignition/docs/guides/upgradeable-proxies Checkout the veLike and vLikeReward from 93da984 and move current code as V2

veLike: Update the velike deployment procedure

c1a434c

rickmak force-pushed the velike-nolock branch from 29c197d to c1a434c Compare March 4, 2026 16:40

rickmak merged commit 604aec4 into likecoin:main Mar 4, 2026
9 checks passed

		$.totalStaked -= amount;
		$.stakerInfos[account].stakedAmount -= amount;

Conversation

rickmak commented Feb 27, 2026

Uh oh!

ckxpress commented Feb 27, 2026

Uh oh!

rickmak commented Feb 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

rickmak commented Mar 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

williamchong Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

rickmak Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

williamchong Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants