Merged
Conversation
nwingt
approved these changes
Feb 2, 2026
williamchong
force-pushed
the
feature/tts-ui
branch
from
e13044b to
ba06999
Compare
williamchong
force-pushed
the
feature/tts-ui
branch
from
ba06999 to
a1390df
Compare
Comment on lines
+64
to
+65
| const consecutiveAudioErrors = ref(0) | ||
| const MAX_CONSECUTIVE_ERRORS = 3 |
There was a problem hiding this comment.
The consecutive error counter should be reset when users manually skip to a different segment (via skipForward, skipBackward, or skipToIndex). Currently, if there are 2 consecutive errors and the user skips forward, the next error would immediately pause playback, even though the user is trying a different segment. Consider resetting the counter when playCurrentElement() is called from user actions, or add a reset in the skip functions themselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.