Update cmake modules to resolve Metal backend build issue for cmake 4.* #1113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Make 4.* These changes sync our CMake modules with the latest from swift-cmake-examples, ensuring compatibility with CMake 4.x and resolving build failures related to the Metal backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates the
cmakemodules to align with the latest implementation from swift-cmake-examples.The update resolves #1063, allowing the Metal backend to be successfully built using
cmake 4.*.Background
The same modification was first introduced and tested in the ChinChangYang#6.
A GitHub Action workflow has already verified this approach on
macos-13withcmake 4.*in ChinChangYang@3cb0e05.Notes
cmakemodules with upstream Swift examples.cmake 4.*and the Metal backend build process.