Merge release/lightspark-sdk-v0.20.1 into main #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
…18.0 Merge release/lightspark-sdk-v0.18.0 into develop
Add the uma-configuration file to the demo VASP
Initial commit - rename vasp1 & vasp 2 to sending/receiving vasp, add skeleton methods for new routes
# Receiver Vasp This PR adds an endpoint to create an invoice, and an endpoint to create invoice + send to another uma address # Testing run a receiver vasp on port 8080, and a sender vasp on 8081 to create an invoice `curl -u <username>:<password> -X POST "http://localhost:8080/api/uma/create_invoice?amount=100¤cyCode=USD"` to create and send an invoice to another uma `curl -u <username>:<password> -X POST "http://localhost:8080/api/uma/create_and_send_invoice/?amount=100¤cyCode=USD&senderUma=<sender uma>"`
# Sender VASP demo endpoints this adds 2 demo endpoints - receive an invoice from a receiver vasp and cache it for later client payment - process a payrequest for a full incoming uma invoice, or a cached invoice # testing run 2 vasps, a receiver vasp on 8080 and a sender vasp on 8081 receiver invoice to sender vasp `curl -u <username>:<password> -X POST "http://localhost:8081/api/uma/request_and_pay_invoice?invoice=<bech32 encoded invoice>"` sender client to sender vasp: `curl -u <username>:<password> -X POST "http://localhost:8081/api/uma/pay_invoice?invoice=<bech32 encoded invoice, or uuid identifying a cached invoice>`
Add explicit timeouts to the Requester
Create SECURITY.md
Regenerating SDKs following introspection of schemas.
This PR was automatically created by the release branch cut workflow.\nSDK=lightspark-sdk\nVERSION=0.19.0 Co-authored-by: runner <[email protected]>
This was accidental copy-pasta.
…19.1 Merge release/lightspark-sdk-v0.19.1 into develop
…urlInvoice, and createUmaInvoice and their respective mutations from all 3 clients.
…nt_has-and-preimage_nonce-parameters Added paymentHash and preimageNonce params to createInvoice functions
…leasepaymentpreimage-function Added releasePaymentPreimage functions to all 3 kotlin clients
Update Gradle version to 8.14.2
Fix misnamed buckets ldev.web-dev -> lsdev.web-dev
Merge release/core-v0.6.1 into develop
…20.0 Merge release/lightspark-sdk-v0.20.0 into develop
Improve webhook request validation and test coverage
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| import com.lightspark.sdk.core.LightsparkException | ||
| import com.lightspark.sdk.model.WebhookEventType | ||
| import com.lightspark.sdk.util.serializerFormat | ||
| import java.security.MessageDigest |
There was a problem hiding this comment.
Critical compilation error: java.security.MessageDigest is imported in commonMain code, but this is a JVM-only class. In Kotlin Multiplatform, commonMain source sets must only use APIs available on all targets (JVM, JS, Native). This will cause compilation failures on JavaScript and Native targets. The import needs to be moved to platform-specific source sets or replaced with a multiplatform-compatible constant-time comparison function.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
shreyav
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically created by the release branch cut workflow.\nSDK=lightspark-sdk\nVERSION=0.20.1