-
Notifications
You must be signed in to change notification settings - Fork 119
feat: mixed prefill-decode batching (part 3: compatibility with speculative decoding for MLA models) #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: mixed prefill-decode batching (part 3: compatibility with speculative decoding for MLA models) #205
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
1878a1a
fix typing
syuoni 92d9bf1
scheduling order
syuoni 27882bb
non-spec path
syuoni 8c5564b
merge o_proj
syuoni 514a8c5
inplace prefill attn output
syuoni f02254c
fix non-mixed spec
syuoni 0901eb6
spec path
syuoni 8ede2cb
fix trtllm_mla
syuoni 67b3810
migrate flashmla
syuoni 00469aa
migrate other attn backends
syuoni 7dfe411
clean num_tokens
syuoni f196575
fix dsv4 ut
syuoni 9ef8fc1
override_num_extends
syuoni 307b1ef
enable mixed batch on CI
syuoni 2f8a7dc
fix doc
syuoni e7db3f0
disable mixed batch on perf CI
syuoni 96ea96e
fix lint
syuoni 6a7b0a1
fix ut
syuoni 0d95c68
unregister test_deepseek_v4_config
syuoni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
_init_forward_metadataswitched from two draft-backend init calls to a single call, EXTEND/MIXED draft batches no longer force a DECODE-shaped metadata refresh before Eagle step 2+.TritonAttnBackendstores only oneforward_metadata, so after the single call it can still hold prefill-styleqo_indptr/kv_indptr; then_run_multi_step_decodeinvokes decode kernels against that stale layout, which can misindex KV ranges or fail on shape assumptions for mixed prefill+decode speculative batches.Useful? React with 👍 / 👎.