Skip to content

Resolve node #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 9, 2025
Merged

Resolve node #513

merged 5 commits into from
Apr 9, 2025

Conversation

sjorsdonkers
Copy link
Contributor

@sjorsdonkers sjorsdonkers commented Apr 7, 2025 •
edited
Loading

ResolveNode implementation.
This PR is only changing CDP DOM, other changes come from #502 including current nullptr issue

Depends on:

sjorsdonkers
sjorsdonkers commented Apr 7, 2025
View reviewed changes
karlseguin
karlseguin reviewed Apr 8, 2025
View reviewed changes
@sjorsdonkers sjorsdonkers changed the base branch from main to cdp_node_children April 8, 2025 06:52
Base automatically changed from cdp_node_children to main April 8, 2025 13:45
sjorsdonkers
sjorsdonkers commented Apr 8, 2025
View reviewed changes
@krichprollsch
Copy link
Member

chromedp dump is working with this PR 🎉

$ cdpcli -cdp ws://127.0.0.1:9222 -runs=1 dump http://127.0.0.1:1234
<html><head>
        <title>Lightpanda Browser demo</title>
        <meta charset="UTF-8">
</head>
<body>
        <h1>Lightpanda Browser Demo</h1>

        <h2><a href="campfire-commerce/">Campfire Commerce</a></h2>
        <a href="campfire-commerce/"><img src="campfire-commerce/images/logo.jpg"></a>
        <p>
                Demo of an e-commerce product offer page with data loaded from XHR request.
                <br>
                All images and texts have been generated with AI.
                Template by <a href="https://codepen.io/Sunil_Pradhan/pen/qBqgLxK">Sunil Pradhan</a>
        </p>


</body></html>total runs                1
total errors            0
total duration          3.947761ms
avg run duration        3.947761ms
min run duration        3.947344ms
max run duration        3.947344ms

@sjorsdonkers sjorsdonkers marked this pull request as ready for review April 9, 2025 09:44
@krichprollsch krichprollsch merged commit 4f0ea88 into main Apr 9, 2025
12 checks passed
@krichprollsch krichprollsch deleted the resolveNode branch April 9, 2025 13:00
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karlseguin karlseguin karlseguin left review comments

@krichprollsch krichprollsch krichprollsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sjorsdonkers @krichprollsch @karlseguin