itest+lntest: make sure to assert edge in both graph db and cache #9420

yyforyongyu · 2025-01-16T08:24:36Z

Fix a flake found in this build,

 --- FAIL: TestLightningNetworkDaemon/tranche07/248-of-269/bitcoind/graph_topology_notifications (93.80s)
        --- FAIL: TestLightningNetworkDaemon/tranche07/248-of-269/bitcoind/graph_topology_notifications/unpinned (37.65s)
            harness_node.go:403: Starting node (name=Bob) with PID=19372
            harness_node.go:403: Starting node (name=Alice) with PID=19574
            lnd_channel_graph_test.go:669: 
                	Error Trace:	/home/runner/work/lnd/lnd/itest/lnd_channel_graph_test.go:669
                	            				/home/runner/work/lnd/lnd/itest/lnd_channel_graph_test.go:292
                	            				/home/runner/work/lnd/lnd/itest/lnd_channel_graph_test.go:260
                	Error:      	Not equal: 
                	            	expected: 1
                	            	actual  : 2
                	Test:       	TestLightningNetworkDaemon/tranche07/248-of-269/bitcoind/graph_topology_notifications/unpinned
            harness.go:375: finished test: graph_topology_notifications, start height=621, end height=623, mined blocks=2
            harness.go:334: test failed, skipped cleanup
        harness.go:375: finished test: graph_topology_notifications, start height=606, end height=623, mined blocks=17
        harness.go:334: test failed, skipped cleanup
    lnd_test.go:138: Failure time: 2025-01-15 14:35:05.182
FAIL

And another flake, which looks like payment-related, but actually it's due to edge not being updated in the graph cache yet,

--- FAIL: TestLightningNetworkDaemon/tranche05/178-of-269/bitcoind/multihop-local_claim_incoming_htlc_anchor_zero_conf (126.76s)
        harness_node.go:403: Starting node (name=Alice) with PID=8140
        harness_node.go:403: Starting node (name=Bob) with PID=8203
        harness_node.go:403: Starting node (name=Carol) with PID=8237
        harness_assertion.go:1259: 
            	Error Trace:	/home/runner/work/lnd/lnd/lntest/harness_assertion.go:1259
            	            				/home/runner/work/lnd/lnd/itest/lnd_multi-hop_force_close_test.go:1698
            	            				/home/runner/work/lnd/lnd/itest/lnd_multi-hop_force_close_test.go:1557
            	            				/home/runner/work/lnd/lnd/lntest/harness.go:297
            	            				/home/runner/work/lnd/lnd/itest/lnd_test.go:130
            	Error:      	Received unexpected error:
            	            	Alice: assert active HTLCs failed: want 1, got: 0, total: 0, previously had: 0
            	Test:       	TestLightningNetworkDaemon/tranche05/178-of-269/bitcoind/multihop-local_claim_incoming_htlc_anchor_zero_conf
            	Messages:   	Alice timeout checking num active htlcs
        harness.go:375: finished test: multihop-local_claim_incoming_htlc_anchor_zero_conf, start height=621, end height=631, mined blocks=10
        harness.go:334: test failed, skipped cleanup

We need to make sure to wait for the `ListPeers` to give us the latest response.

coderabbitai · 2025-01-16T08:24:43Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

guggero

LGTM 🎉

ziggie1984

LGTM, but still a clarifying question regarding the graph cache.

lntest/harness_assertion.go

We need to make sure the channel edge has been updated in both the graph DB and cache.

guggero · 2025-01-16T15:22:06Z

Looks like we've got a failure in the new checks:

     --- FAIL: TestLightningNetworkDaemon/tranche09/156-of-269/bitcoind/receiver_blinded_error (57.25s)
        harness_node.go:403: Starting node (name=Alice) with PID=14745
        harness_node.go:403: Starting node (name=Bob) with PID=14777
        harness_node.go:403: Starting node (name=Carol) with PID=14805
        harness_node.go:403: Starting node (name=Dave) with PID=14878
        harness_assertion.go:1879: 
            	Error Trace:	/home/runner/work/lnd/lnd/lntest/harness_assertion.go:1879
            	            				/home/runner/work/lnd/lnd/lntest/harness_assertion.go:1937
            	            				/home/runner/work/lnd/lnd/lntest/harness.go:2353
            	            				/home/runner/work/lnd/lnd/lntest/harness.go:2219
            	            				/home/runner/work/lnd/lnd/itest/lnd_route_blinding_test.go:373
            	            				/home/runner/work/lnd/lnd/itest/lnd_route_blinding_test.go:631
            	            				/home/runner/work/lnd/lnd/lntest/harness.go:297
            	            				/home/runner/work/lnd/lnd/itest/lnd_test.go:130
            	Error:      	Received unexpected error:
            	            	channel 90033bd9f64e9aeff15f8730927a56b7192c3d835ddfa6b0ad9fbd7fff2ec131:0 not found in graph: rpc error: code = Unknown desc = edge not found: op=90033bd9f64e9aeff15f8730927a56b7192c3d835ddfa6b0ad9fbd7fff2ec131:0
            	Test:       	TestLightningNetworkDaemon/tranche09/156-of-269/bitcoind/receiver_blinded_error
            	Messages:   	Dave: timeout finding channel in graph

Perhaps that's just uncovering a new (pre-existing) problem, so not really an issue with this PR per se.

yyforyongyu · 2025-01-16T15:26:46Z

Perhaps that's just uncovering a new (pre-existing) problem, so not really an issue with this PR per see.

yeah it's related to a gossip bug which I have a fix coming up soon

itest: fix flake in graph_topology_notifications

848f42e

We need to make sure to wait for the `ListPeers` to give us the latest response.

yyforyongyu added flake fix no-changelog size/micro small bug fix or feature, less than 15 mins of review, less than 250 labels Jan 16, 2025

guggero approved these changes Jan 16, 2025

View reviewed changes

ziggie1984 self-requested a review January 16, 2025 09:24

ziggie1984 approved these changes Jan 16, 2025

View reviewed changes

lntest/harness_assertion.go Show resolved Hide resolved

yyforyongyu added 2 commits January 16, 2025 23:00

itest: fix docs

e576d66

lntest: assert channel edge in both graph db and cache

faa1f67

We need to make sure the channel edge has been updated in both the graph DB and cache.

yyforyongyu force-pushed the assert-channel-graph branch from 42be2fd to faa1f67 Compare January 16, 2025 15:01

yyforyongyu merged commit e0a920a into lightningnetwork:master Jan 16, 2025
31 of 34 checks passed

yyforyongyu deleted the assert-channel-graph branch January 16, 2025 16:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

itest+lntest: make sure to assert edge in both graph db and cache #9420

itest+lntest: make sure to assert edge in both graph db and cache #9420

yyforyongyu commented Jan 16, 2025

coderabbitai bot commented Jan 16, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

guggero left a comment

ziggie1984 left a comment

guggero commented Jan 16, 2025

yyforyongyu commented Jan 16, 2025

itest+lntest: make sure to assert edge in both graph db and cache #9420

itest+lntest: make sure to assert edge in both graph db and cache #9420

Conversation

yyforyongyu commented Jan 16, 2025

coderabbitai bot commented Jan 16, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

guggero left a comment

Choose a reason for hiding this comment

ziggie1984 left a comment

Choose a reason for hiding this comment

guggero commented Jan 16, 2025

yyforyongyu commented Jan 16, 2025

CodeRabbit Configuration File (`.coderabbit.yaml`)