-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: manage shutdown requests with status codes #9395
base: master
Are you sure you want to change the base?
multi: manage shutdown requests with status codes #9395
Conversation
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
3890076
to
9ff0861
Compare
9ff0861
to
496d8e1
Compare
In this commit, we manage shutdown requests with status codes. Exits with code 1 for critical errors (e.g, from exhausted attempts connecting to chain backend), and code 0 for normal shutdowns (e.g., from Stop Daemon RPC call). Co-authored-by: Elle Mouton <[email protected]>
496d8e1
to
1714d8c
Compare
Change Description
In this commit, we handle shutdown requests with status codes:
Replaces #8659
Closes #5625
Additional Context
Credits
Steps to Test
Steps for reviewers to follow to test the change.
Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]
in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.