lnd: use persisted node announcement settings across restarts #8825

Abdulkbk · 2024-06-10T17:38:42Z

replaces #8690

Change Description

This change allows a node to retain its previously configured node announcement settings after a restart, making it more consistent.

Issue:
As mentioned in the issue description:

If you set your alias using the UpdateNodeAnnouncement RPC call it will only maintain this as an update until a restart. Restarting clears all of the node announcement settings.

This creates additional work for users; for instance, if you have a list of addresses you associated with your node using the updatenodeannouncement RPC, you need to set them again each time your node restarts.

This also applies to all fields that can be updated using the updatenodeannouncement RPC, including: alias, color, addresses, and feature bit.

Solution:
This update checks for existing node announcement settings and reuses them during startup.

Since the node announcement settings can be set either through the node's config (specified in lnd.conf or passed as command line args) or using the updatenodeannouncement RPC, the hierarchy of precedence for these settings is as follows:

We check for what's set in config (args or lnd.conf)
We check for persistent settings (from graphDB)
We resolve to defaults

Steps to Test

Install LND with the peersrpc tag: make install tags="peersrpc".

Test for precedence:

Set one of the fields in the lnd.conf file, for example, alias=alice.
Start LND and update the alias by running: lncli peers updatenodeannouncement -alias=bob.
Verify that the alias has been updated using the lncli getinfo command.
Restart LND, then run lncli getinfo again to confirm that the alias is now set to alice.

Test for persistence

Start LND without configuring one of the fields in the lnd.conf file.
Use the command lncli peers updatenodeannouncement -color=#000000 to update the node's color, and verify the change by running lncli getinfo.
Restart LND, and then execute lncli getinfo again to ensure that the color value remains the same after the restart.

Pull Request Checklist

Testing

Your PR passes all CI checks.
Tests covering the positive and negative (error paths) are included.
Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
Commits follow the Ideal Git Commit Structure.
Any new logging statements use an appropriate subsystem and logging level.
Any new lncli commands have appropriate tags in the comments for the rpc in the proto file.
There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our Contribution Guidelines for further guidance.

coderabbitai · 2024-06-10T17:38:47Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Abdulkbk · 2024-06-10T17:45:14Z

@ellemouton, this pull request replaces #8690 as per your suggestion here. Please review when you have time. Thanks

ellemouton · 2024-06-10T17:48:58Z

@Abdulkbk - thanks! Although I think you could have just updated the commits in the original PR - no need for a new PR :)

Abdulkbk · 2024-06-10T19:20:12Z

@Abdulkbk - thanks! Although I think you could have just updated the commits in the original PR - no need for a new PR :)

At first, I thought about doing that, but then I ended up creating a new PR. Thanks for the feedback; I'm really learning a lot.

Abdulkbk · 2024-06-11T17:18:05Z

Hi @alexbosworth, I've opened this PR to fix the issue #7123 you reported. Could you spare some time to review it? Your input will help me improve the solution.

alexbosworth

utconcept ack

Chinwendu20

Nice work. Left some suggestions. I think the commit message does not follow guideline (i.e. length of the message):
https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md#model-git-commit-messages

Here 6ebec6148ef072bd5cddc7, I do not think this is necessary:
'''
lnd: refactor code to elliminate duplicate nill check

lnd: fix comment
'''

Also I think this needs a release note? Maybe add here: https://github.com/lightningnetwork/lnd/blob/7065b6462edf48f3c86a58f2fd215cb0db2c0474/docs/release-notes/release-notes-0.18.1.md

server.go

Abdulkbk · 2024-06-23T20:38:03Z

Also I think this needs a release note? Maybe add here: https://github.com/lightningnetwork/lnd/blob/7065b6462edf48f3c86a58f2fd215cb0db2c0474/docs/release-notes/release-notes-0.18.1.md

Since this PR persists whatever was previously updated with the updatenodeannouncement lncli command, it means I should add a bullet point to explain that, right? @Chinwendu20

Chinwendu20 · 2024-06-25T20:45:32Z

I think you can add a bullet point to talk about what the change actually is and maybe a short explanation. Maybe under functional updates

Abdulkbk · 2024-06-26T10:45:24Z

I think you can add a bullet point to talk about what the change actually is and maybe a short explanation. Maybe under functional updates

I just noticed that the issue this PR is addressing is under milestone 0.19.0. Shouldn't the milestone version and release notes version be the same?

Chinwendu20 · 2024-06-26T13:04:16Z

I think it makes sense that it should be the same.

server.go

Abdulkbk · 2024-07-11T21:44:16Z

Hi @yyforyongyu , I noticed that you are one of the code owners of netann. This PR touches nodeannouncement, which I think falls under that. Would you mind reviewing it? It is required before I can get the tests to run.

yyforyongyu

Approved CI run.

server.go

Abdulkbk · 2024-11-04T20:28:31Z

Could you help approve the CI, @yyforyongyu?

lightninglabs-deploy · 2024-12-31T00:43:55Z

@yyforyongyu: review reminder
@Chinwendu20: review reminder
@Abdulkbk, remember to re-request review from reviewers when ready

This commit ensures that we start with the alias, node color, addresses, and features as advertised in the node's previous runtime. This approach maintains consistency in the node's advertised information across restarts.

alexbosworth approved these changes Jun 11, 2024

View reviewed changes

Chinwendu20 reviewed Jun 13, 2024

View reviewed changes

server.go Outdated Show resolved Hide resolved

server.go Outdated Show resolved Hide resolved

server.go Outdated Show resolved Hide resolved

Abdulkbk force-pushed the restore-node-announcement branch from e2a4aa2 to b1e6571 Compare June 13, 2024 22:17

saubyk assigned Abdulkbk Jun 27, 2024

alexbosworth reviewed Jul 3, 2024

View reviewed changes

server.go Outdated Show resolved Hide resolved

Abdulkbk force-pushed the restore-node-announcement branch from b1e6571 to 5acc286 Compare July 9, 2024 14:33

saubyk added this to the v0.19.0 milestone Jul 12, 2024

yyforyongyu reviewed Jul 16, 2024

View reviewed changes

server.go Outdated Show resolved Hide resolved

Abdulkbk force-pushed the restore-node-announcement branch 2 times, most recently from 19d2ab7 to 367fbb7 Compare July 29, 2024 21:41

Abdulkbk force-pushed the restore-node-announcement branch 2 times, most recently from 61d4c75 to e43254e Compare August 6, 2024 22:41

Abdulkbk requested review from yyforyongyu and Chinwendu20 August 6, 2024 22:42

Abdulkbk force-pushed the restore-node-announcement branch from e43254e to 59462a5 Compare October 26, 2024 21:41

Abdulkbk force-pushed the restore-node-announcement branch from 59462a5 to d3fa798 Compare December 19, 2024 18:04

Abdulkbk force-pushed the restore-node-announcement branch from d3fa798 to 0c08783 Compare January 3, 2025 10:16

lnd: use saved node ann config from previous run

6b2e8b7

This commit ensures that we start with the alias, node color, addresses, and features as advertised in the node's previous runtime. This approach maintains consistency in the node's advertised information across restarts.

docs: add release note

26b09ed

Abdulkbk force-pushed the restore-node-announcement branch from 0c08783 to 26b09ed Compare January 3, 2025 23:16

Abdulkbk changed the title ~~lnd: use persisted node announcement data from previous runtime~~ lnd: use persisted node announcement settings across restarts Jan 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lnd: use persisted node announcement settings across restarts #8825

lnd: use persisted node announcement settings across restarts #8825

Abdulkbk commented Jun 10, 2024 •

edited

Loading

coderabbitai bot commented Jun 10, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Abdulkbk commented Jun 10, 2024

ellemouton commented Jun 10, 2024

Abdulkbk commented Jun 10, 2024

Abdulkbk commented Jun 11, 2024

alexbosworth left a comment

Chinwendu20 left a comment •

edited

Loading

Abdulkbk commented Jun 23, 2024

Chinwendu20 commented Jun 25, 2024

Abdulkbk commented Jun 26, 2024

Chinwendu20 commented Jun 26, 2024

Abdulkbk commented Jul 11, 2024

yyforyongyu left a comment

Abdulkbk commented Nov 4, 2024

lightninglabs-deploy commented Dec 31, 2024

lnd: use persisted node announcement settings across restarts #8825

Are you sure you want to change the base?

lnd: use persisted node announcement settings across restarts #8825

Conversation

Abdulkbk commented Jun 10, 2024 • edited Loading

Change Description

Steps to Test

Pull Request Checklist

Testing

Code Style and Documentation

coderabbitai bot commented Jun 10, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Abdulkbk commented Jun 10, 2024

ellemouton commented Jun 10, 2024

Abdulkbk commented Jun 10, 2024

Abdulkbk commented Jun 11, 2024

alexbosworth left a comment

Choose a reason for hiding this comment

Chinwendu20 left a comment • edited Loading

Choose a reason for hiding this comment

Abdulkbk commented Jun 23, 2024

Chinwendu20 commented Jun 25, 2024

Abdulkbk commented Jun 26, 2024

Chinwendu20 commented Jun 26, 2024

Abdulkbk commented Jul 11, 2024

yyforyongyu left a comment

Choose a reason for hiding this comment

Abdulkbk commented Nov 4, 2024

lightninglabs-deploy commented Dec 31, 2024

Abdulkbk commented Jun 10, 2024 •

edited

Loading

coderabbitai bot commented Jun 10, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

Chinwendu20 left a comment •

edited

Loading