macaroons: reject unknown macaroon versions #8132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
force-pushed
the
strict-macaroon-version
branch
from
0e2520f to
72647e4
Compare
yyforyongyu
reviewed
Oct 31, 2023
Crypt-iQ
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
LGTM once @yyforyongyu comment is addressed 🥍
EDIT: The macaroon_authentication/invalid_macaroon itest is failing because the error string "cannot get macaroon" should be replaced by "invalid ID"
Roasbeef
force-pushed
the
strict-macaroon-version
branch
2 times, most recently
from
0152523 to
f2562d7
Compare
We've only ever made macaroons with the v2 versions, so we should explicitly reject those that aren't actually v2. We add a basic test along the way, and also add a similar check for the version encoded in the macaroon ID.
Roasbeef
force-pushed
the
strict-macaroon-version
branch
from
f2562d7 to
9287b75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've only ever made macaroons with the v2 versions, so we should explicitly reject those that aren't actually v2. We add a basic test along the way, and also add a similar check for the version encoded in the macaroon ID.