-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix amount field #8097
Fix amount field #8097
Conversation
6ca6dd8
to
54af4fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉Thank you very much for picking this up @marekttes. The PR is neat and clean.
I only have a question about the MinConfs
check in the server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I think the CLI needs a couple of changes, otherwise the code looks okay.
Can you please make sure you check the pull request check list? The commits should be squashed into two, one for the RPC changes and one for the CLI. And a change log entry for the 0.18 release should be added to docs/release-notes/release-notes-v0.18.md
.
5729049
to
13b9079
Compare
@markettes - see the guidelines for how to model commit titles. For your commits, it would probably be along the lines of: Please also remove the merge commit 🙏 instead, rebase on master before pushing |
9fa8111
to
92dba38
Compare
92dba38
to
a072e19
Compare
All done @ellemouton 😄 |
The linter is failing because of a line that is longer than 80 characters (you need to count tabs as 8 spaces, best to set up your IDE that way to make it easier). |
a14899e
to
0cd39c2
Compare
Ready now @guggero, sorry, my bad! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for working on this! I think we can remove an else statement to improve readability.
4b79e52
to
133f36e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more nits, otherwise looks, thanks!
6ea8d71
to
7445782
Compare
This PR attempts to solve #8038
Change Description
Description of change / link to associated issue.
Steps to Test
Steps for reviewers to follow to test the change.
Pull Request Checklist
Testing
Code Style and Documentation
[skip ci]
in the commit message for small changes.📝 Please see our Contribution Guidelines for further guidance.