supplycommit: add MultiStateMachineManager for managing group state machines #1643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffranr
added
the
supply commit
|
@guggero have i defined |
Pull Request Test Coverage Report for Build 16339924797Details
💛 - Coveralls |
Roasbeef
requested changes
Jul 10, 2025
ffranr
force-pushed
the
wip/supplycommit/add-multi-sm-manager
branch
2 times, most recently
from
1cf0088 to
d538aec
Compare
guggero
reviewed
Jul 11, 2025
ffranr
force-pushed
the
wip/supplycommit/add-multi-sm-manager
branch
from
d538aec to
8d1dd7e
Compare
ffranr
force-pushed
the
wip/supplycommit/add-multi-sm-manager
branch
2 times, most recently
from
0433cc0 to
09a1823
Compare
Roasbeef
approved these changes
Jul 16, 2025
There was a problem hiding this comment.
LGTM 🚝
Reviewed 15 of 15 files at r1, 12 of 12 files at r2, all commit messages.
Reviewable status: all files reviewed, 13 unresolved discussions (waiting on @ffranr and @guggero)
|
Can land after a rebase! |
This change separates the keyring interface from the wallet interface, allowing integration with an existing keyring service instead of extending the wallet service. We also use DeriveNextTaprootAssetKey as a simplification.
Add context argument to `SupplyTreeView` interface methods to allow `tapdb.SupplyTreeStore` to satisfy the interface.
Introduces `DefaultCommitConfTarget`, a constant for the default confirmation target (in blocks) for a supply commitment transaction. This constant provides a sensible default for fee estimation, ensuring that the commitment transaction is confirmed in a timely manner without overpaying. Centralizing this value makes it easier to manage and adjust in the future. If we don't set `CommitConfTarget` field in state machine env to a reasonable value fee estimation will fail.
The state machine that curates a supply commit transaction is specific to an asset group key. To manage multiple such state machines across asset groups at the RPC layer, introduce the MultiStateMachineManager. The manager caches separate state machines for each asset group.
Populate the SupplyCommitManager field in the config so that the rpcserver can invoke methods on the supply commitment manager.
This allows derivation of PSBT BIP32 paths for a keychain.KeyDescriptor using network-specific parameters. The new field is unread in this commit but will be used later.
Introduce LndFsmDaemonAdapters, a struct implementing the protofsm.DaemonAdapters interface. This is passed into supplycommit.NewMultiStateMachineManager, which then propagates it to each asset group-specific state machine.
chain_bridge.go now contains multiple Lightning clients: invoices, transport, and router. The new name lnd_services.go reflects this richer scope and improves discoverability.
In this commit, we add logic to resend trigger events for select states. Along the way, we modify the way the state machine works: we can avoid having to extract the PSBT again, just by reading it from the state transition.
ffranr
force-pushed
the
wip/supplycommit/add-multi-sm-manager
branch
from
09a1823 to
a3cbff2
Compare
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Taproot-Assets Project Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work towards completing #1534
These commits are split out from #1554
This PR introduces the
MultiStateMachineManager, a service that manages supply commitment state machines for multiple asset groups. Each state machine is scoped to a specific asset group. TheMultiStateMachineManagercaches and orchestrates these group-specific machines, providing a unified interface for the RPC server to start, query, and stop them.This change is