taprpc: support custom lock ID and expiration in CommitVirtualPsbts #1475
+272
−218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14645882357Details
💛 - Coveralls |
bhandras
force-pushed
the
commitvirtualpsbts-custom-lock
branch
from
5b19896 to
e41c34c
Compare
|
Update: ready for review. |
bhandras
force-pushed
the
commitvirtualpsbts-custom-lock
branch
2 times, most recently
from
7f64735 to
f4ca881
Compare
This change extends the CommitVirtualPsbts RPC to accept an optional custom UTXO lock ID and lease expiration. By enabling callers to define these parameters explicitly, the wallet can better coordinate UTXO locking across concurrent workflows and provide safer, more flexible transaction retargeting when using virtual PSBTs. If unset, the default internal lock ID and 10-minute expiration remain in effect, preserving backward compatibility.
bhandras
force-pushed
the
commitvirtualpsbts-custom-lock
branch
from
f4ca881 to
51a9f0b
Compare
GeorgeTsagk
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extends the CommitVirtualPsbts RPC to accept an optional custom UTXO lock ID and lease expiration. By enabling callers to define these parameters explicitly, the wallet can better coordinate UTXO locking across concurrent workflows and provide safer, more flexible transaction retargeting during PSBT construction.
If unset, the default internal lock ID and 10-minute expiration remain in effect, preserving backward compatibility.
depends on: lightningnetwork/lnd#9724