[custom channels]: enforce minimum amounts #921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeTsagk
approved these changes
Dec 13, 2024
Yeah, I'll squash them into the existing commits of the |
ffranr
reviewed
Dec 13, 2024
cmd/litcli/ln.go
Outdated
| @@ -182,6 +182,15 @@ var ( | |||
| "set if there are multiple channels with the same " + | |||
| "asset ID present", | |||
| } | |||
|
|
|||
| allowUnEconomicalFlag = cli.BoolFlag{ | |||
There was a problem hiding this comment.
How about allowOverpay or allowAssetOverpay or allowTotalValueOverpay
I think allowTotalValueOverpay is most clear.
There was a problem hiding this comment.
Couldn't see this change in the latest commits. Are they incoming?
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
1f4a0cd to
d59c717
Compare
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
d59c717 to
76e65f1
Compare
|
@guggero does this need a rebase before I review? |
guggero
force-pushed
the
enforce-min-amount
branch
from
2abe2a5 to
c887c4c
Compare
guggero
force-pushed
the
enforce-min-amount
branch
from
c887c4c to
addaa56
Compare
ffranr
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on lightninglabs/taproot-assets#1252.
Adds test cases for the new minimum amount enforcement introduced in above PR.