-
Notifications
You must be signed in to change notification settings - Fork 102
[custom channels]: enforce minimum amounts #921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 🥼
commits need reorder to compile individually
Yeah, I'll squash them into the existing commits of the |
cmd/litcli/ln.go
Outdated
@@ -182,6 +182,15 @@ var ( | |||
"set if there are multiple channels with the same " + | |||
"asset ID present", | |||
} | |||
|
|||
allowUnEconomicalFlag = cli.BoolFlag{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about allowOverpay
or allowAssetOverpay
or allowTotalValueOverpay
I think allowTotalValueOverpay
is most clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't see this change in the latest commits. Are they incoming?
1f4a0cd
to
d59c717
Compare
d59c717
to
76e65f1
Compare
@guggero does this need a rebase before I review? |
2abe2a5
to
c887c4c
Compare
c887c4c
to
addaa56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a "check commit" lint error but otherwise ok.
Depends on lightninglabs/taproot-assets#1252.
Adds test cases for the new minimum amount enforcement introduced in above PR.