Skip to content

mod+itest: bump tapd, assert asset decimal display #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

guggero
Copy link
Member

@guggero guggero commented Dec 6, 2024

Depends on lightninglabs/taproot-assets#1245.

Asserts the decimal display value for all pending and opened channels.

@guggero guggero self-assigned this Dec 6, 2024
@dstadulis dstadulis added this to the tapd v0.5 milestone Dec 6, 2024
@dstadulis dstadulis added the tests label Dec 6, 2024
@guggero guggero requested a review from GeorgeTsagk December 9, 2024 10:19
@guggero guggero force-pushed the decimal-display-funding-blob branch from 251a9aa to a551501 Compare December 9, 2024 10:19
Copy link
Member

@GeorgeTsagk GeorgeTsagk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + tACK

@guggero guggero requested a review from ffranr December 9, 2024 12:29
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍡

@Roasbeef Roasbeef merged commit 8ac370b into update-to-lnd-18-4 Dec 9, 2024
12 of 13 checks passed
@guggero guggero deleted the decimal-display-funding-blob branch December 10, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants