Fix litcli sendpayment panic #911
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes the asset units may not be sufficient to carry out a payment (depending on the granularity and asset price). This may be lead to calculating "zero" units for a payment. This pr fixes a small piece of code that would blindly divide by
numUnits
without checking whether it's zero. If it's zero we need to error out as this means the payment cannot be carried out.Solution
If we have
numUnits
equal to 0 we skip the division that would cause the panic, and instead return an error to the user which looks like thisRelated issues
Closes lightninglabs/taproot-assets#1230