Skip to content

Add itest for multi input asset funding #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

gijswijs
Copy link
Contributor

The itest testCustomChannelsMultiInput verifies multi-input channel funding.
In this test Charlie mints an asset, transfers it to Dave in two
separate txs. Dave then uses both asset UTXOs to fund a channel with
Charlie that is bigger than the value of either UTXO.

Add testCustomChannelsMultiInput to verify multi-input channel funding.
In this test Charlie mints an asset, transfers it to Dave in two
separate txs. Dave then uses both asset UTXOs to fund a channel with
Charlie that is bigger than the value of either UTXO.
@gijswijs gijswijs linked an issue Oct 23, 2024 that may be closed by this pull request
1 task
@dstadulis dstadulis requested a review from guggero October 24, 2024 12:49
@ffranr ffranr self-requested a review October 24, 2024 12:52
@dstadulis dstadulis added this to the tapd v0.4.2 milestone Oct 24, 2024
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, LGTM 🎉

// Send the first asset to Dave.
itest.AssertAddrCreated(t.t, daveTap, cents, daveAddr1)
sendResp, err := charlieTap.SendAsset(ctxb, &taprpc.SendAssetRequest{
TapAddrs: []string{daveAddr1.Encoded},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could send to both addresses at the same time here.

Copy link
Contributor

@ffranr ffranr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking, perhaps consider the test name: testCustomChannelsSingleAssetMultiInput
Leaves room for multi-asset channel itest.

@guggero guggero merged commit eb2784e into update-to-lnd-18-4 Oct 28, 2024
12 of 13 checks passed
@guggero guggero deleted the test-multi-input-asset-funding branch October 28, 2024 10:08
@guggero
Copy link
Member

guggero commented Oct 28, 2024

Gonna address the nits in the base branch which I need to rebase anyway.

@gijswijs gijswijs mentioned this pull request Oct 31, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add tests exercising fundchannel
4 participants