itest: add <354 sats payment coverage for custom channels #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage for the current behavior. |
dstadulis
changed the title
|
This PR should now base against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds coverage for the scenario where an asset invoice worth less than 354 sats is paid for with sats (from a node that is not the RFQ peer).
This case triggers a specific code check in lnd where the incoming/outgoing sats produce a negative fee
(see related issue)
The current expected status of the payment is set to
lnrpc.PAYMENT_FAILEDas this has not yet been patched.This itest will be updated in order to expect a
lnrpc.PAYMENT_SUCCEEDEDonce this behavior is fixed in lnd(see related PR for tracking)