feat: Make MonitorUpdatingPersister change persist type based on size #3834
+155
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @tnull as a reviewer! |
joostjager
reviewed
Jun 9, 2025
| /// For small channel monitors (below `minimum_monitor_size_for_updates` bytes when serialized), | ||
| /// this persister will always write the full monitor instead of individual updates. This avoids | ||
| /// the overhead of managing update files and later compaction for tiny monitors that don't benefit | ||
| /// from differential updates. |
There was a problem hiding this comment.
It is still not clear to me how much the gain is of this in practice. Also worried that disabling the incremental path initially allow certain bugs to linger for longer, just because the path isn't hit as much, or rarely.
tnull
reviewed
Jun 10, 2025
| @@ -458,6 +465,7 @@ where | |||
| kv_store: K, | |||
| logger: L, | |||
| maximum_pending_updates: u64, | |||
| minimum_monitor_size_for_updates: usize, | |||
There was a problem hiding this comment.
Please specify the unit of size in the variable name if possible.
| /// in full rather than using update-based persistence. | ||
| /// | ||
| /// For other parameters, see [`MonitorUpdatingPersister::new`]. | ||
| pub fn new_with_default_threshold( |
There was a problem hiding this comment.
Hmm, should we rather leave new the one applying the default threshold and rather add a new_with_monitor_size_threshold or similar constructor?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3770
minimum_monitor_size_for_updatesto specify the minimum size for full persistence to be activatednew_with_default_thresholdfunction to setupMonitorUpdatingPersisterwith a defaultminimum_monitor_size_for_updatesvalue