Skip to content

Move and Rustfmt channel acceptance and type downgrade tests #3797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

carlaKC
Copy link
Contributor

@carlaKC carlaKC commented May 23, 2025

This PR moves tests related to channel acceptance / type downgrade into their own file (out of channelmanager) and formats them.

Depends on #3792 as requested in review.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented May 23, 2025

👋 I see @jkczyz was un-assigned.
If you'd like another reviewer assignemnt, please click here.

Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 97.59036% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.88%. Comparing base (0848e7a) to head (9388bba).

Files with missing lines Patch % Lines
lightning/src/ln/channel_acceptance_tests.rs 97.59% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3797   +/-   ##
=======================================
  Coverage   89.87%   89.88%           
=======================================
  Files         160      161    +1     
  Lines      129654   129700   +46     
  Branches   129654   129700   +46     
=======================================
+ Hits       116531   116579   +48     
- Misses      10428    10429    +1     
+ Partials     2695     2692    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ldk-reviews-bot ldk-reviews-bot requested a review from jkczyz May 23, 2025 18:41
@ldk-reviews-bot
Copy link

🔔 1st Reminder

Hey @jkczyz! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot
Copy link

🔔 2nd Reminder

Hey @jkczyz! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@carlaKC carlaKC removed the request for review from jkczyz May 28, 2025 18:52
@carlaKC
Copy link
Contributor Author

carlaKC commented May 28, 2025

Removing bot-reviewer until dependent PR is in.

@carlaKC carlaKC changed the title rustfmt: move channel acceptance tests into own file and format Move and Rustfmt channel acceptance and type Downgrade tests Jun 4, 2025
@carlaKC carlaKC changed the title Move and Rustfmt channel acceptance and type Downgrade tests Move and Rustfmt channel acceptance and type downgrade tests Jun 4, 2025
@carlaKC carlaKC force-pushed the refactor-chantype-tests branch 2 times, most recently from 8e347da to a204e88 Compare June 4, 2025 20:44
@carlaKC carlaKC force-pushed the refactor-chantype-tests branch from a204e88 to 9388bba Compare June 9, 2025 13:02
@carlaKC carlaKC added the weekly goal Someone wants to land this this week label Jun 9, 2025
@ldk-reviews-bot ldk-reviews-bot requested a review from wpaulino June 9, 2025 14:12
@ldk-reviews-bot
Copy link

✅ Added second reviewer: @wpaulino

Copy link
Contributor

@tankyleo tankyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more tests that caught my eye in channelmanager:

test_drop_disconnected_peers_when_removing_channels
test_drop_peers_when_removing_unfunded_channels
test_connection_limiting
test_outbound_chans_unlimited
test_0conf_limiting

What do you think ?

Otherwise, reproduced and matched everything so far on my machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
weekly goal Someone wants to land this this week
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants