-
Notifications
You must be signed in to change notification settings - Fork 412
Move and Rustfmt channel acceptance and type downgrade tests #3797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👋 I see @jkczyz was un-assigned. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3797 +/- ##
=======================================
Coverage 89.88% 89.88%
=======================================
Files 160 161 +1
Lines 129654 129700 +46
Branches 129654 129700 +46
=======================================
+ Hits 116534 116579 +45
- Misses 10425 10429 +4
+ Partials 2695 2692 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🔔 1st Reminder Hey @jkczyz! This PR has been waiting for your review. |
🔔 2nd Reminder Hey @jkczyz! This PR has been waiting for your review. |
Removing bot-reviewer until dependent PR is in. |
a204e88
to
9388bba
Compare
✅ Added second reviewer: @wpaulino |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more tests that caught my eye in channelmanager:
test_drop_disconnected_peers_when_removing_channels
test_drop_peers_when_removing_unfunded_channels
test_connection_limiting
test_outbound_chans_unlimited
test_0conf_limiting
What do you think ?
Otherwise, reproduced and matched everything so far on my machine.
9a562c3
to
b360b9b
Compare
b360b9b
to
ca852a2
Compare
These look like good candidates for a move so added them the others are less compelling to me so going to leave them out. |
🔔 1st Reminder Hey @wpaulino! This PR has been waiting for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM mod small CI fix
This PR moves tests related to channel acceptance / type downgrade into their own file (out of channelmanager) and formats them.
Depends on #3792as requested in review.