Skip to content

Allow either node to send tx_init_rbf in v2 establishment #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow either node to send tx_init_rbf in v2 establishment #1236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion 02-peer-protocol.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1407,7 +1407,10 @@ a transaction paying more fees to make the channel confirm faster.
#### Requirements

The sender of `tx_init_rbf`:
- MUST be the *initiator*
- MAY be either the *initiator* or the *accepter*
- If the sender is the accepter, it becomes the initiator of the `interactive-tx` session and thus:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Looking at updating CLN to accommodate this, and ran into a question which seems obvious but wanted to confirm.

I'm taking this to mean that the serial_ids and all other role-related indicators are swapped for the entirety of the tx construction phase?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct

- MUST send `tx_add_output` for the channel output
- MUST pay the fees for the shared transaction fields
- MUST NOT have sent or received a `channel_ready` message.

The recipient:
Expand All @@ -1430,6 +1433,10 @@ a large feerate change, instead sets their `sats` to zero, and decline to
participate further in the channel funding: by not contributing, they
may obtain incoming liquidity at no cost.

We allow both nodes to initiate RBF, because any one of them may want to take
this opportunity to contribute additional funds to the channel without
waiting for the initial funding transaction to confirm.

## Channel Quiescence

Various fundamental changes, in particular protocol upgrades, are
Expand Down