Clarify the sighash types for HTLC Success and Timeout transactions #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the option to report an remote IP address back to a connecting peer using the `init` message. A node can decide to use that information to discover a potential update to its public IPv4 address (NAT) and use that for a `node_announcement` update message containing the new address. The proposal includes reporting the IPv4 and IPv6 address, however in IPv6 there are likely no NAT issues. TOR is skipped for obvious reasons. Certain approaches to check and use this information are thinkable: - Wait for multiple peers or a certain fraction to report the same new address. - Check some random node known via gossip to also report the new address. - Verify this information by making a test connection to itself.
|
ACK |
devrandom
approved these changes
Jan 15, 2022
…ng#951) Prior to the addition of `warning` messages, BOLT 5 specified a few cases where users should be warned that funds may have been lost. However, it used the phrasing "send a warning" which can now be confused with `warning` messages. Nodes should not generally inform their counterparty that they have been robbed.
BOLT 1: adds remote address to optional init_tlvs (IP discovery)
…ightning#942) If a node has to fail a channel but knows that its latest commitment transaction is outdated it should not be required to send it but rather wait for the peer to unilaterally close the channel. The proposed solution is not so clean because it might produce a deadlock in which two peers assume they have outdated state and send `error` back and forth without actually force closing. Maybe in such a scenario we could create a protocol that mutually closes with split balance? Also replaced the word use with broadcast as it seems more accurate. Co-authored-by: t-bast <[email protected]>
ksedgwic
force-pushed
the
clarify-htlc-anchor-sighash
branch
from
0b0aa55 to
655915c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.