Skip to content

annotations: adjustment to support multiple sample types #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LeonardoRosaa merged 17 commits into from
Dec 10, 2025
Merged

annotations: adjustment to support multiple sample types #280

LeonardoRosaa merged 17 commits into from
Dec 10, 2025

Conversation

@LeonardoRosaa
Copy link
Contributor

@LeonardoRosaa LeonardoRosaa commented Dec 9, 2025 •
edited
Loading

What has changed and why?

Minor adjustments to the annotation endpoint to more easily support multiple sample types.

Key changes:

  • The sample type is now defined by the parent dataset (backend change to support this, as it is difficult to define the annotation sample type otherwise).
  • The video and video frame sample type are the same for now.
  • Return the parent sample type.

How has it been tested?

Unit tests.

Did you update CHANGELOG.md?

  • Yes
  • Not needed (internal change)

@LeonardoRosaa LeonardoRosaa changed the title Leonardo lig 8223 enable annotation page for videos annotation grid: introduce video support Dec 9, 2025
@LeonardoRosaa LeonardoRosaa marked this pull request as ready for review December 9, 2025 18:31
michal-lightly
michal-lightly requested changes Dec 10, 2025
View reviewed changes
@LeonardoRosaa LeonardoRosaa changed the title annotation grid: introduce video support annotations: adjustment to support multiple sample types Dec 10, 2025
michal-lightly
michal-lightly approved these changes Dec 10, 2025
View reviewed changes
@LeonardoRosaa LeonardoRosaa merged commit 2d5e8ef into main Dec 10, 2025
9 checks passed
@LeonardoRosaa LeonardoRosaa deleted the leonardo-lig-8223-enable-annotation-page-for-videos branch December 10, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michal-lightly michal-lightly michal-lightly approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LeonardoRosaa @michal-lightly